From a3faca910f1c31f6f1dab90844205b20e34f1c64 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Thu, 29 Feb 2024 16:12:59 +0100 Subject: [PATCH] :paperclip: Add some FIXME comments for future refactors --- frontend/src/app/main/refs.cljs | 3 ++- frontend/src/app/main/ui/viewer/inspect/code.cljs | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/src/app/main/refs.cljs b/frontend/src/app/main/refs.cljs index 534cc0cbc2..969bb43a65 100644 --- a/frontend/src/app/main/refs.cljs +++ b/frontend/src/app/main/refs.cljs @@ -539,6 +539,7 @@ (every? (partial ctl/grid-layout-immediate-child? objects)))) workspace-page-objects =)) +;; FIXME: move to viewer.inspect.code (defn get-flex-child-viewer [ids page-id] (l/derived @@ -550,7 +551,7 @@ ids))) st/state =)) - +;; FIXME: move to viewer.inspect.code (defn get-viewer-objects ([] (let [route (deref route) diff --git a/frontend/src/app/main/ui/viewer/inspect/code.cljs b/frontend/src/app/main/ui/viewer/inspect/code.cljs index a4e44ca43e..08acf69c9b 100644 --- a/frontend/src/app/main/ui/viewer/inspect/code.cljs +++ b/frontend/src/app/main/ui/viewer/inspect/code.cljs @@ -50,7 +50,9 @@ ") -(defn get-flex-elements [page-id shapes from] +;; FIXME: rename to hook naming convention +(defn get-flex-elements + [page-id shapes from] (let [ids (mapv :id shapes) ids (hooks/use-equal-memo ids) @@ -63,6 +65,7 @@ (mf/deref get-layout-children-refs))) +;; FIXME: rename to hook naming convention (defn get-objects [from] (let [page-objects-ref (mf/use-memo