github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-25 11:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix blur affecting extra shapes

Browse Source
This commit is contained in:
Alejandro Alonso 2026-03-03 08:32:28 +01:00
parent 585a2d7523
commit 9fa027c1df
4 changed files with 3611 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3583
frontend/playwright/data/render-wasm/get-file-blurs-affecting-other-elements.json Normal file
View File

File diff suppressed because it is too large Load Diff

20
frontend/playwright/ui/render-wasm-specs/shapes.spec.js
View File

@ -455,4 +455,24 @@ test("Check inner stroke artifacts", async ({
maxDiffPixelRatio: 0,
threshold: 0.1,
});
});
test("BUG 13551 - Blurs affecting other elements", async ({
page,
}) => {
const workspace = new WasmWorkspacePage(page);
await workspace.setupEmptyFile();
await workspace.mockGetFile("render-wasm/get-file-blurs-affecting-other-elements.json");
await workspace.goToWorkspace({
id: "effcbebc-b8c8-802f-8007-a7dc677169cd",
pageId: "a5508528-5928-8008-8007-a7de9feef61bd",
});
await workspace.waitForFirstRenderWithoutUI();
// Stricter comparison: blur is very subtle
await expect(workspace.canvas).toHaveScreenshot({
maxDiffPixelRatio: 0,
threshold: 0.1,
});
});

BIN
frontend/playwright/ui/render-wasm-specs/shapes.spec.js-snapshots/BUG-13551---Blurs-affecting-other-elements-1.png Normal file
View File

Binary file not shown.
Side by Side

After

Width:  |  Height:  |  Size: 11 KiB

10
render-wasm/src/render.rs
View File

@ -53,6 +53,8 @@ pub struct NodeRenderState {
visited_mask: bool,
// This bool indicates that we're drawing the mask shape.
mask: bool,
// True when this container was flattened (enter/exit skipped).
flattened: bool,
}
/// Get simplified children of a container, flattening nested flattened containers
@ -1462,6 +1464,7 @@ impl RenderState {
clip_bounds: None,
visited_mask: true,
mask: false,
flattened: false,
});
if let Some(&mask_id) = element.mask_id() {
self.pending_nodes.push(NodeRenderState {
@ -1470,6 +1473,7 @@ impl RenderState {
clip_bounds: None,
visited_mask: false,
mask: true,
flattened: false,
});
}
}
@ -1999,8 +2003,7 @@ impl RenderState {
}
if visited_children {
// Skip render_shape_exit for flattened containers
if !element.can_flatten() {
if !node_render_state.flattened {
self.render_shape_exit(element, visited_mask, clip_bounds);
}
continue;
@ -2149,6 +2152,7 @@ impl RenderState {
clip_bounds: clip_bounds.clone(),
visited_mask: false,
mask,
flattened: can_flatten,
});
if element.is_recursive() {
@ -2195,6 +2199,7 @@ impl RenderState {
clip_bounds: children_clip_bounds.clone(),
visited_mask: false,
mask: false,
flattened: false,
});
}
}
@ -2309,6 +2314,7 @@ impl RenderState {
clip_bounds: None,
visited_mask: false,
mask: false,
flattened: false,
}
}));
}