github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-08-14 16:58:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix invitation loop (#11223)

Browse Source
This commit is contained in:
Eva Marco 2026-08-12 13:20:21 +02:00 committed by GitHub
parent e5c80edbf3
commit 986ee60cad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
frontend/src/app/main/ui/dashboard/team.cljs
View File

@ -19,6 +19,7 @@
[app.main.data.team :as dtm] [app.main.data.team :as dtm]
[app.main.refs :as refs] [app.main.refs :as refs]
[app.main.repo :as rp] [app.main.repo :as rp]
[app.main.router :as rt]
[app.main.store :as st] [app.main.store :as st]
[app.main.ui.alert] [app.main.ui.alert]
[app.main.ui.components.dropdown :refer [dropdown]] [app.main.ui.components.dropdown :refer [dropdown]]
@ -87,6 +88,7 @@
route (mf/deref refs/route) route (mf/deref refs/route)
invite-email (-> route :query-params :invite-email) invite-email (-> route :query-params :invite-email)
team-id (:id team)
members-section? (= section :dashboard-team-members) members-section? (= section :dashboard-team-members)
settings-section? (= section :dashboard-team-settings) settings-section? (= section :dashboard-team-settings)
@ -101,15 +103,20 @@
on-invite-member on-invite-member
(mf/use-fn (mf/use-fn
(mf/deps team invite-email) (mf/deps team-id invite-email)
(fn [] (fn []
(st/emit! (dtm/check-and-invite-members {:team-id (:id team) (st/emit! (dtm/check-and-invite-members {:team-id team-id
:origin :team :origin :team
:invite-email invite-email}))))] :invite-email invite-email}))))]
(mf/with-effect [team invite-email] ;; Depend on `team-id` (stable) rather than `team` (a map whose
(when invite-email ;; reference changes on every teams/members fetch) and clear
(on-invite-member))) ;; `invite-email` from the URL once consumed, so this can't
;; keep re-triggering `check-and-invite-members` in a loop.
(mf/with-effect [team-id invite-email]
(when (and team-id invite-email)
(on-invite-member)
(st/emit! (rt/nav (get-in route [:data :name]) {:team-id team-id} {::rt/replace true}))))
[:header {:class (stl/css :dashboard-header :team) :data-testid "dashboard-header"} [:header {:class (stl/css :dashboard-header :team) :data-testid "dashboard-header"}
[:div {:class (stl/css :dashboard-title)} [:div {:class (stl/css :dashboard-title)}