github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-29 05:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

🚧 WIP Step 12.4, Comments

Browse Source 
AI-assisted-by: gpt6-astra
This commit is contained in:
Miguel de Benito Delgado 2026-09-27 18:55:26 +02:00
parent 5224a54cb7
commit 9356c3a225
3 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/test/benches/render_wasm/cases.cljs
View File

@ -4,6 +4,13 @@
;;
;; Copyright (c) KALEIDOS SUBSIDIARY SL
;; Discovery loads each scene and its transitive requires, including any
;; colocated operation functions. Stripping :run! only makes output plain
;; data; it cannot isolate browser dependencies. Keep this entire import
;; graph safe for Node. Browser adapters supply execution capabilities in
;; rtx; discovery must never invoke operation bodies. Ticket 06 must prove
;; collection with a real pan body present, not just metadata-only cases.
(ns benches.render-wasm.cases
"Case collection for the renderer benchmarks.

20
frontend/test/benches/render_wasm/scenes/core.cljs
View File

@ -47,6 +47,26 @@
;; tickets 05/06/14; this namespace fixes the binding name, the single
;; threaded value, and the body shape checked below.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Node/browser dependency contract (runtime wiring pending in ticket 06)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Scene declarations and bodies load in both Node and browser. Only the
;; browser driver executes bodies. Their transitive imports must stay safe
;; for Node; removing :run! from descriptors does not isolate dependencies.
;;
;; If an operation needs a browser API/helper, keep that import in a browser
;; adapter and pass a narrow function or prepared resource through rtx.
;; Keep pure calculations in portable helpers. Define arguments, return or
;; promise completion, timing and cleanup ownership for each capability.
;; Resource acquisition normally belongs to untimed preparation. Reuse
;; existing capabilities before adding one; never import the adapter back
;; into a scene, even if the operation body is not called during discovery.
;;
;; This keeps metadata and bodies together with one declaration authority,
;; at the cost of portable imports and a maintained capability contract.
;; If unrelated services accumulate in rtx, revisit this design explicitly.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Schemas
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

5
frontend/test/benches/render_wasm/scenes/rects.cljs
View File

@ -30,6 +30,11 @@
[benches.render-wasm.scenes.builder :as sb :include-macros true]
[benches.render-wasm.scenes.core :as core :include-macros true]))
;; This namespace is also loaded by Node discovery. Keep operation helpers
;; portable: browser API/helper imports belong in browser adapters supplied
;; through rtx, not in this require list or its transitive dependencies.
;; See scenes.core's dependency contract before adding a capability.
(def ^:private default-params
{:count 1000
:width 1920