github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-29 05:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Make the base the only snapshot a file-gc test relies on

Browse Source 
The save in file-gc-keeps-the-fragments-a-base-names took an automatic
snapshot of pre-edit main, which names the same fragments as the branch
base, so the test passed even with bases left out of liveness. It now
drops every other snapshot before the pass.

AI-assisted-by: claude-opus-5-5
Signed-off-by: Álvaro Tejero Cantero <alvorithm@teje.ro>
This commit is contained in:
Álvaro Tejero Cantero 2026-10-28 11:48:04 +01:00
parent e53719f2b7
commit 7e5099727a
No known key found for this signature in database
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
backend/test/backend_tests/branch_pointer_base_test.clj
View File

@ -173,6 +173,14 @@
(let [main-ids (set (vals (page-pointer-ids
(:data (bfc/get-file th/*system* file-id)))))]
(t/is (seq (remove main-ids pinned))))
;; the save took an automatic snapshot of pre-edit main, which names
;; the same fragments; drop every snapshot but the base so the base
;; is what keeps them alive
(let [base-id (:base-snapshot-id (th/db-get :file-branch {:id (:id branch)}))]
(th/db-exec! ["delete from file_data where file_id = ? and type = 'snapshot' and id <> ?"
file-id base-id])
(th/db-exec! ["delete from file_change where file_id = ? and label is not null and id <> ?"
file-id base-id]))
(t/is (true? (th/run-task! :file-gc {:file-id file-id})))
(t/is (every? (live-fragment-ids file-id) pinned))