github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-25 11:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

⚡ Remove spurious deps from toggle callbacks in text-menu*

Browse Source 
toggle-main-menu and toggle-more-options close over a state atom and
need no external deps. The declared deps (main-menu-open? /
more-options-open?) were unused inside the function bodies, causing
each callback to be reallocated on every toggle — self-reinforcing
churn. Drop the mf/deps calls to make both callbacks stable.

Signed-off-by: Andrey Antukh <niwi@niwi.nz>
This commit is contained in:
Andrey Antukh 2026-04-22 06:35:22 +00:00 committed by Belén Albeza
parent 74d1288003
commit 7751d9a69b
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/app/main/ui/workspace/sidebar/options/menus/text.cljs
View File

@ -348,12 +348,10 @@
;; --- Toggles ;; --- Toggles
toggle-main-menu toggle-main-menu
(mf/use-fn (mf/use-fn
(mf/deps main-menu-open?)
#(swap! menu-state* update :main-menu not)) #(swap! menu-state* update :main-menu not))
toggle-more-options toggle-more-options
(mf/use-fn (mf/use-fn
(mf/deps more-options-open?)
#(swap! menu-state* update :more-options not)) #(swap! menu-state* update :more-options not))
toggle-token-dropdown toggle-token-dropdown