github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-02 16:56:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Remove team design review (#11881)

Browse Source
This commit is contained in:
Marina López 2026-09-25 10:42:29 +02:00 committed by GitHub
parent f35e12f716
commit 76b9c1c859
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
backend/src/app/rpc/management/nitrate.clj
View File

@ -153,13 +153,25 @@
;; ---- API: notify-team-change ;; ---- API: notify-team-change
(def ^:private schema:notify-team-change
[:or
cto/schema:team-with-organization
[:map
[:id ::sm/uuid]
[:organization
[:map
[:name ::sm/text]]]]])
(sv/defmethod ::notify-team-change (sv/defmethod ::notify-team-change
"Notify to Penpot a team change from nitrate" "Notify to Penpot a team change from nitrate"
{::doc/added "2.18" {::doc/added "2.18"
::sm/params cto/schema:team-with-organization ::sm/params schema:notify-team-change
::rpc/auth false} ::rpc/auth false}
[cfg team] [cfg team]
(notifications/notify-team-change cfg (select-keys team [:id :is-your-penpot :organization]) nil) (let [team (select-keys team [:id :is-your-penpot :organization])
notification (when-not (get-in team [:organization :id])
"dashboard.team-no-longer-belong-organization")]
(notifications/notify-team-change cfg team notification))
nil) nil)
;; ---- API: notify-user-added-to-organization ;; ---- API: notify-user-added-to-organization

20
backend/test/backend_tests/rpc_management_nitrate_test.clj
View File

@ -255,6 +255,26 @@
(t/is (= (:owner-id organization) (-> msg :team :organization :owner-id))) (t/is (= (:owner-id organization) (-> msg :team :organization :owner-id)))
(t/is (= (:avatar-bg-url organization) (str (-> msg :team :organization :avatar-bg-url))))))) (t/is (= (:avatar-bg-url organization) (str (-> msg :team :organization :avatar-bg-url)))))))
(t/deftest notify-team-removal-publishes-event
(let [team-id (uuid/random)
organization-name "OrgA"
calls (atom [])
out (with-redefs [mbus/pub! (fn [_cfg & {:keys [topic message]}]
(swap! calls conj {:topic topic
:message message}))]
(th/management-command! {::th/type :notify-team-change
:id team-id
:organization {:name organization-name}}))]
(t/is (th/success? out))
(t/is (= 1 (count @calls)))
(t/is (= uuid/zero (-> @calls first :topic)))
(let [msg (-> @calls first :message)]
(t/is (= :team-organization-change (:type msg)))
(t/is (= "dashboard.team-no-longer-belong-organization" (:notification msg)))
(t/is (= team-id (-> msg :team :id)))
(t/is (= organization-name (-> msg :team :organization :name)))
(t/is (nil? (-> msg :team :organization :id))))))
(t/deftest notify-user-added-to-organization-creates-default-organization-team (t/deftest notify-user-added-to-organization-creates-default-organization-team
(with-mocks [nitrate-mock {:target 'app.nitrate/call (with-mocks [nitrate-mock {:target 'app.nitrate/call
:return (fn [_ m _] :return (fn [_ m _]