mirror of
https://github.com/penpot/penpot.git
synced 2026-05-17 22:13:39 +00:00
♻️ Move app.common.types.color tests to their own namespace
Tests that exercise app.common.types.color were living inside common-tests.colors-test alongside the app.common.colors tests. Move them to common-tests.types.color-test so the test namespace mirrors the source namespace structure, consistent with the rest of the types/ test suite. The [app.common.types.color :as colors] require is removed from colors_test.cljc; the new file is registered in runner.cljc. Signed-off-by: Andrey Antukh <niwi@niwi.nz>
This commit is contained in:
Andrey Antukh
parent
1e0f10814e
commit
6d1d044588
@ -9,91 +9,8 @@
|
||||
#?(:cljs [goog.color :as gcolors])
|
||||
[app.common.colors :as c]
|
||||
[app.common.math :as mth]
|
||||
[app.common.types.color :as colors]
|
||||
[clojure.test :as t]))
|
||||
|
||||
(t/deftest valid-hex-color
|
||||
(t/is (false? (colors/valid-hex-color? nil)))
|
||||
(t/is (false? (colors/valid-hex-color? "")))
|
||||
(t/is (false? (colors/valid-hex-color? "#")))
|
||||
(t/is (false? (colors/valid-hex-color? "#qqqqqq")))
|
||||
(t/is (true? (colors/valid-hex-color? "#aaa")))
|
||||
(t/is (false? (colors/valid-hex-color? "#aaaa")))
|
||||
(t/is (true? (colors/valid-hex-color? "#fabada"))))
|
||||
|
||||
(t/deftest valid-rgb-color
|
||||
(t/is (false? (colors/valid-rgb-color? nil)))
|
||||
(t/is (false? (colors/valid-rgb-color? "")))
|
||||
(t/is (false? (colors/valid-rgb-color? "()")))
|
||||
(t/is (true? (colors/valid-rgb-color? "(255, 30, 30)")))
|
||||
(t/is (true? (colors/valid-rgb-color? "rgb(255, 30, 30)"))))
|
||||
|
||||
(t/deftest rgb-to-str
|
||||
(t/is (= "rgb(1,2,3)" (colors/rgb->str [1 2 3])))
|
||||
(t/is (= "rgba(1,2,3,4)" (colors/rgb->str [1 2 3 4]))))
|
||||
|
||||
(t/deftest rgb-to-hsv
|
||||
;; (prn (colors/rgb->hsv [1 2 3]))
|
||||
;; (prn (gcolors/rgbToHsv 1 2 3))
|
||||
(t/is (= [210.0 0.6666666666666666 3.0] (colors/rgb->hsv [1.0 2.0 3.0])))
|
||||
#?(:cljs (t/is (= (colors/rgb->hsv [1 2 3]) (vec (gcolors/rgbToHsv 1 2 3))))))
|
||||
|
||||
(t/deftest hsv-to-rgb
|
||||
(t/is (= [1 2 3]
|
||||
(colors/hsv->rgb [210 0.6666666666666666 3])))
|
||||
#?(:cljs
|
||||
(t/is (= (colors/hsv->rgb [210 0.6666666666666666 3])
|
||||
(vec (gcolors/hsvToRgb 210 0.6666666666666666 3))))))
|
||||
|
||||
(t/deftest rgb-to-hex
|
||||
(t/is (= "#010203" (colors/rgb->hex [1 2 3]))))
|
||||
|
||||
(t/deftest hex-to-rgb
|
||||
(t/is (= [0 0 0] (colors/hex->rgb "#kkk")))
|
||||
(t/is (= [1 2 3] (colors/hex->rgb "#010203"))))
|
||||
|
||||
(t/deftest format-hsla
|
||||
(t/is (= "210, 50%, 0.78%, 1" (colors/format-hsla [210.0 0.5 0.00784313725490196 1])))
|
||||
(t/is (= "220, 5%, 30%, 0.8" (colors/format-hsla [220.0 0.05 0.3 0.8]))))
|
||||
|
||||
(t/deftest format-rgba
|
||||
(t/is (= "210, 199, 12, 0.08" (colors/format-rgba [210 199 12 0.08])))
|
||||
(t/is (= "210, 199, 12, 1" (colors/format-rgba [210 199 12 1]))))
|
||||
|
||||
(t/deftest rgb-to-hsl
|
||||
(t/is (= [210.0 0.5 0.00784313725490196] (colors/rgb->hsl [1 2 3])))
|
||||
#?(:cljs (t/is (= (colors/rgb->hsl [1 2 3])
|
||||
(vec (gcolors/rgbToHsl 1 2 3))))))
|
||||
|
||||
(t/deftest hsl-to-rgb
|
||||
(t/is (= [1 2 3] (colors/hsl->rgb [210.0 0.5 0.00784313725490196])))
|
||||
(t/is (= [210.0 0.5 0.00784313725490196] (colors/rgb->hsl [1 2 3])))
|
||||
#?(:cljs (t/is (= (colors/hsl->rgb [210 0.5 0.00784313725490196])
|
||||
(vec (gcolors/hslToRgb 210 0.5 0.00784313725490196))))))
|
||||
|
||||
(t/deftest expand-hex
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "a")))
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "aa")))
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "aaa")))
|
||||
(t/is (= "aaaa" (colors/expand-hex "aaaa"))))
|
||||
|
||||
(t/deftest prepend-hash
|
||||
(t/is "#aaa" (colors/prepend-hash "aaa"))
|
||||
(t/is "#aaa" (colors/prepend-hash "#aaa")))
|
||||
|
||||
(t/deftest remove-hash
|
||||
(t/is "aaa" (colors/remove-hash "aaa"))
|
||||
(t/is "aaa" (colors/remove-hash "#aaa")))
|
||||
|
||||
(t/deftest color-string-pred
|
||||
(t/is (true? (colors/color-string? "#aaa")))
|
||||
(t/is (true? (colors/color-string? "(10,10,10)")))
|
||||
(t/is (true? (colors/color-string? "rgb(10,10,10)")))
|
||||
(t/is (true? (colors/color-string? "magenta")))
|
||||
(t/is (false? (colors/color-string? nil)))
|
||||
(t/is (false? (colors/color-string? "")))
|
||||
(t/is (false? (colors/color-string? "kkkkkk"))))
|
||||
|
||||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
|
||||
;; app.common.colors tests
|
||||
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
|
||||
@ -387,82 +304,3 @@
|
||||
(t/is (= 0.25 (c/reduce-range 0.3 4)))
|
||||
(t/is (= 0.0 (c/reduce-range 0.0 10))))
|
||||
|
||||
;; --- Gradient helpers (app.common.types.color)
|
||||
|
||||
(t/deftest types-interpolate-color
|
||||
(t/testing "at c1 offset returns c1 color"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 0.0)]
|
||||
(t/is (= "#000000" (:color result)))
|
||||
(t/is (= 0.0 (:opacity result)))))
|
||||
(t/testing "at c2 offset returns c2 color"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 1.0)]
|
||||
(t/is (= "#ffffff" (:color result)))
|
||||
(t/is (= 1.0 (:opacity result)))))
|
||||
(t/testing "at midpoint returns interpolated gray"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 0.5)]
|
||||
(t/is (= "#7f7f7f" (:color result)))
|
||||
(t/is (mth/close? (:opacity result) 0.5)))))
|
||||
|
||||
(t/deftest types-uniform-spread
|
||||
(t/testing "produces correct count and offsets"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
stops (colors/uniform-spread c1 c2 3)]
|
||||
(t/is (= 3 (count stops)))
|
||||
(t/is (= 0.0 (:offset (first stops))))
|
||||
(t/is (mth/close? 0.5 (:offset (second stops))))
|
||||
(t/is (= 1.0 (:offset (last stops))))))
|
||||
(t/testing "single stop returns a vector of one element (no division by zero)"
|
||||
(let [c1 {:color "#ff0000" :opacity 1.0 :offset 0.0}
|
||||
stops (colors/uniform-spread c1 c1 1)]
|
||||
(t/is (= 1 (count stops))))))
|
||||
|
||||
(t/deftest types-uniform-spread?
|
||||
(t/testing "uniformly spread stops are detected as uniform"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
stops (colors/uniform-spread c1 c2 3)]
|
||||
(t/is (true? (colors/uniform-spread? stops)))))
|
||||
(t/testing "two-stop gradient is uniform by definition"
|
||||
(let [stops [{:color "#ff0000" :opacity 1.0 :offset 0.0}
|
||||
{:color "#0000ff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (true? (colors/uniform-spread? stops)))))
|
||||
(t/testing "stops with wrong offset are not uniform"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#888888" :opacity 0.5 :offset 0.3}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (false? (colors/uniform-spread? stops)))))
|
||||
(t/testing "stops with correct offset but wrong color are not uniform"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#aaaaaa" :opacity 0.5 :offset 0.5}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (false? (colors/uniform-spread? stops))))))
|
||||
|
||||
(t/deftest types-interpolate-gradient
|
||||
(t/testing "at start offset returns first stop color"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 0.0)]
|
||||
(t/is (= "#000000" (:color result)))))
|
||||
(t/testing "at end offset returns last stop color"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 1.0)]
|
||||
(t/is (= "#ffffff" (:color result)))))
|
||||
(t/testing "at midpoint returns interpolated gray"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 0.5)]
|
||||
(t/is (= "#7f7f7f" (:color result)))))
|
||||
(t/testing "offset beyond last stop returns last stop color (nil idx guard)"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 0.5}]
|
||||
result (colors/interpolate-gradient stops 1.0)]
|
||||
(t/is (= "#ffffff" (:color result))))))
|
||||
|
||||
|
||||
@ -54,6 +54,7 @@
|
||||
[common-tests.text-test]
|
||||
[common-tests.time-test]
|
||||
[common-tests.types.absorb-assets-test]
|
||||
[common-tests.types.color-test]
|
||||
[common-tests.types.components-test]
|
||||
[common-tests.types.container-test]
|
||||
[common-tests.types.fill-test]
|
||||
@ -126,6 +127,7 @@
|
||||
'common-tests.text-test
|
||||
'common-tests.time-test
|
||||
'common-tests.types.absorb-assets-test
|
||||
'common-tests.types.color-test
|
||||
'common-tests.types.components-test
|
||||
'common-tests.types.container-test
|
||||
'common-tests.types.fill-test
|
||||
|
||||
166
common/test/common_tests/types/color_test.cljc
Normal file
166
common/test/common_tests/types/color_test.cljc
Normal file
@ -0,0 +1,166 @@
|
||||
;; This Source Code Form is subject to the terms of the Mozilla Public
|
||||
;; License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
;; file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
||||
;;
|
||||
;; Copyright (c) KALEIDOS INC
|
||||
|
||||
(ns common-tests.types.color-test
|
||||
(:require
|
||||
[app.common.math :as mth]
|
||||
[app.common.types.color :as colors]
|
||||
[clojure.test :as t]))
|
||||
|
||||
;; --- Predicates
|
||||
|
||||
(t/deftest valid-hex-color
|
||||
(t/is (false? (colors/valid-hex-color? nil)))
|
||||
(t/is (false? (colors/valid-hex-color? "")))
|
||||
(t/is (false? (colors/valid-hex-color? "#")))
|
||||
(t/is (false? (colors/valid-hex-color? "#qqqqqq")))
|
||||
(t/is (true? (colors/valid-hex-color? "#aaa")))
|
||||
(t/is (false? (colors/valid-hex-color? "#aaaa")))
|
||||
(t/is (true? (colors/valid-hex-color? "#fabada"))))
|
||||
|
||||
(t/deftest valid-rgb-color
|
||||
(t/is (false? (colors/valid-rgb-color? nil)))
|
||||
(t/is (false? (colors/valid-rgb-color? "")))
|
||||
(t/is (false? (colors/valid-rgb-color? "()")))
|
||||
(t/is (true? (colors/valid-rgb-color? "(255, 30, 30)")))
|
||||
(t/is (true? (colors/valid-rgb-color? "rgb(255, 30, 30)"))))
|
||||
|
||||
;; --- Conversions
|
||||
|
||||
(t/deftest rgb-to-str
|
||||
(t/is (= "rgb(1,2,3)" (colors/rgb->str [1 2 3])))
|
||||
(t/is (= "rgba(1,2,3,4)" (colors/rgb->str [1 2 3 4]))))
|
||||
|
||||
(t/deftest rgb-to-hsv
|
||||
(t/is (= [210.0 0.6666666666666666 3.0] (colors/rgb->hsv [1.0 2.0 3.0]))))
|
||||
|
||||
(t/deftest hsv-to-rgb
|
||||
(t/is (= [1 2 3]
|
||||
(colors/hsv->rgb [210 0.6666666666666666 3]))))
|
||||
|
||||
(t/deftest rgb-to-hex
|
||||
(t/is (= "#010203" (colors/rgb->hex [1 2 3]))))
|
||||
|
||||
(t/deftest hex-to-rgb
|
||||
(t/is (= [0 0 0] (colors/hex->rgb "#kkk")))
|
||||
(t/is (= [1 2 3] (colors/hex->rgb "#010203"))))
|
||||
|
||||
(t/deftest format-hsla
|
||||
(t/is (= "210, 50%, 0.78%, 1" (colors/format-hsla [210.0 0.5 0.00784313725490196 1])))
|
||||
(t/is (= "220, 5%, 30%, 0.8" (colors/format-hsla [220.0 0.05 0.3 0.8]))))
|
||||
|
||||
(t/deftest format-rgba
|
||||
(t/is (= "210, 199, 12, 0.08" (colors/format-rgba [210 199 12 0.08])))
|
||||
(t/is (= "210, 199, 12, 1" (colors/format-rgba [210 199 12 1]))))
|
||||
|
||||
(t/deftest rgb-to-hsl
|
||||
(t/is (= [210.0 0.5 0.00784313725490196] (colors/rgb->hsl [1 2 3]))))
|
||||
|
||||
(t/deftest hsl-to-rgb
|
||||
(t/is (= [1 2 3] (colors/hsl->rgb [210.0 0.5 0.00784313725490196])))
|
||||
(t/is (= [210.0 0.5 0.00784313725490196] (colors/rgb->hsl [1 2 3]))))
|
||||
|
||||
(t/deftest expand-hex
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "a")))
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "aa")))
|
||||
(t/is (= "aaaaaa" (colors/expand-hex "aaa")))
|
||||
(t/is (= "aaaa" (colors/expand-hex "aaaa"))))
|
||||
|
||||
(t/deftest prepend-hash
|
||||
(t/is "#aaa" (colors/prepend-hash "aaa"))
|
||||
(t/is "#aaa" (colors/prepend-hash "#aaa")))
|
||||
|
||||
(t/deftest remove-hash
|
||||
(t/is "aaa" (colors/remove-hash "aaa"))
|
||||
(t/is "aaa" (colors/remove-hash "#aaa")))
|
||||
|
||||
(t/deftest color-string-pred
|
||||
(t/is (true? (colors/color-string? "#aaa")))
|
||||
(t/is (true? (colors/color-string? "(10,10,10)")))
|
||||
(t/is (true? (colors/color-string? "rgb(10,10,10)")))
|
||||
(t/is (true? (colors/color-string? "magenta")))
|
||||
(t/is (false? (colors/color-string? nil)))
|
||||
(t/is (false? (colors/color-string? "")))
|
||||
(t/is (false? (colors/color-string? "kkkkkk"))))
|
||||
|
||||
;; --- Gradient helpers
|
||||
|
||||
(t/deftest interpolate-color
|
||||
(t/testing "at c1 offset returns c1 color"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 0.0)]
|
||||
(t/is (= "#000000" (:color result)))
|
||||
(t/is (= 0.0 (:opacity result)))))
|
||||
(t/testing "at c2 offset returns c2 color"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 1.0)]
|
||||
(t/is (= "#ffffff" (:color result)))
|
||||
(t/is (= 1.0 (:opacity result)))))
|
||||
(t/testing "at midpoint returns interpolated gray"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
result (colors/interpolate-color c1 c2 0.5)]
|
||||
(t/is (= "#7f7f7f" (:color result)))
|
||||
(t/is (mth/close? (:opacity result) 0.5)))))
|
||||
|
||||
(t/deftest uniform-spread
|
||||
(t/testing "produces correct count and offsets"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
stops (colors/uniform-spread c1 c2 3)]
|
||||
(t/is (= 3 (count stops)))
|
||||
(t/is (= 0.0 (:offset (first stops))))
|
||||
(t/is (mth/close? 0.5 (:offset (second stops))))
|
||||
(t/is (= 1.0 (:offset (last stops))))))
|
||||
(t/testing "single stop returns a vector of one element (no division by zero)"
|
||||
(let [c1 {:color "#ff0000" :opacity 1.0 :offset 0.0}
|
||||
stops (colors/uniform-spread c1 c1 1)]
|
||||
(t/is (= 1 (count stops))))))
|
||||
|
||||
(t/deftest uniform-spread?
|
||||
(t/testing "uniformly spread stops are detected as uniform"
|
||||
(let [c1 {:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
c2 {:color "#ffffff" :opacity 1.0 :offset 1.0}
|
||||
stops (colors/uniform-spread c1 c2 3)]
|
||||
(t/is (true? (colors/uniform-spread? stops)))))
|
||||
(t/testing "two-stop gradient is uniform by definition"
|
||||
(let [stops [{:color "#ff0000" :opacity 1.0 :offset 0.0}
|
||||
{:color "#0000ff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (true? (colors/uniform-spread? stops)))))
|
||||
(t/testing "stops with wrong offset are not uniform"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#888888" :opacity 0.5 :offset 0.3}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (false? (colors/uniform-spread? stops)))))
|
||||
(t/testing "stops with correct offset but wrong color are not uniform"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#aaaaaa" :opacity 0.5 :offset 0.5}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]]
|
||||
(t/is (false? (colors/uniform-spread? stops))))))
|
||||
|
||||
(t/deftest interpolate-gradient
|
||||
(t/testing "at start offset returns first stop color"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 0.0)]
|
||||
(t/is (= "#000000" (:color result)))))
|
||||
(t/testing "at end offset returns last stop color"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 1.0)]
|
||||
(t/is (= "#ffffff" (:color result)))))
|
||||
(t/testing "at midpoint returns interpolated gray"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 1.0}]
|
||||
result (colors/interpolate-gradient stops 0.5)]
|
||||
(t/is (= "#7f7f7f" (:color result)))))
|
||||
(t/testing "offset beyond last stop returns last stop color (nil idx guard)"
|
||||
(let [stops [{:color "#000000" :opacity 0.0 :offset 0.0}
|
||||
{:color "#ffffff" :opacity 1.0 :offset 0.5}]
|
||||
result (colors/interpolate-gradient stops 1.0)]
|
||||
(t/is (= "#ffffff" (:color result))))))
|
||||
Loading…
x
Reference in New Issue
Block a user