From 604edb83ebd314c8674d185d84ebd5ea7ffc5b88 Mon Sep 17 00:00:00 2001
From: Andrey Antukh <niwi@niwi.nz>
Date: Thu, 23 Apr 2026 16:36:15 +0000
Subject: [PATCH] :zap: Extract extract-id-from-event helper to deduplicate
 snapshot callbacks

Three callbacks in snapshot-entry* shared the same DOM extraction logic
(get current target, read data-id, parse UUID). Extracted into a private
defn- to remove the duplication and simplify each callback.
---
 .../main/ui/workspace/sidebar/versions.cljs   | 28 +++++++------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/frontend/src/app/main/ui/workspace/sidebar/versions.cljs b/frontend/src/app/main/ui/workspace/sidebar/versions.cljs
index 5e3909f91e..96c0e1068e 100644
--- a/frontend/src/app/main/ui/workspace/sidebar/versions.cljs
+++ b/frontend/src/app/main/ui/workspace/sidebar/versions.cljs
@@ -81,6 +81,10 @@
   [event]
   (dom/select-text! (dom/get-target event)))
 
+(defn- extract-id-from-event
+  [event]
+  (-> event dom/get-current-target (dom/get-data "id") uuid/parse))
+
 (mf/defc version-entry*
   {::mf/private true}
   [{:keys [entry current-profile on-preview on-restore on-delete on-rename on-lock on-unlock on-edit on-cancel-edit is-editing]}]
@@ -225,34 +229,22 @@
         (mf/use-fn
          (mf/deps on-pin-snapshot)
          (fn [event]
-           (let [node  (dom/get-current-target event)
-                 id    (-> node
-                           (dom/get-data "id")
-                           (uuid/parse))]
-             (when (fn? on-pin-snapshot)
-               (on-pin-snapshot id event)))))
+           (when (fn? on-pin-snapshot)
+             (on-pin-snapshot (extract-id-from-event event) event))))
 
         on-restore-snapshot
         (mf/use-fn
          (mf/deps on-restore-snapshot)
          (fn [event]
-           (let [node  (dom/get-current-target event)
-                 id    (-> node
-                           (dom/get-data "id")
-                           (uuid/parse))]
-             (when (fn? on-restore-snapshot)
-               (on-restore-snapshot id event)))))
+           (when (fn? on-restore-snapshot)
+             (on-restore-snapshot (extract-id-from-event event) event))))
 
         on-preview-snapshot
         (mf/use-fn
          (mf/deps on-preview-snapshot)
          (fn [event]
-           (let [node  (dom/get-current-target event)
-                 id    (-> node
-                           (dom/get-data "id")
-                           (uuid/parse))]
-             (when (fn? on-preview-snapshot)
-               (on-preview-snapshot id event)))))
+           (when (fn? on-preview-snapshot)
+             (on-preview-snapshot (extract-id-from-event event) event))))
 
         on-open-snapshot-menu
         (mf/use-fn