github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-07-03 21:05:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Accept delay 0 in plugin API interaction setter

Browse Source 
The InteractionProxy `delay` setter rejected `0` via `(not (pos? value))`,
so an immediate after-delay interaction (`interaction.delay = 0`) was
refused. The model allows it: `set-delay`
(common/.../shape/interactions.cljc) only asserts `check-safe-int`, with
no positivity constraint, and `safe-int` permits 0.

Replace the guard with `(or (not (sm/valid-safe-int? value)) (neg? value))`:
it allows 0 and positive integers, rejects negatives, and rejects
non-integers cleanly (the previous `number?` check let fractional values
through, which then failed the model's `check-safe-int` assertion
downstream).

Adds a regression test (delay round-trips a positive value, then 0).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Filip Sajdak <filip.sajdak@siili.com>
This commit is contained in:
Filip Sajdak 2026-06-23 00:24:36 +02:00 committed by Alonso Torres
parent 1c5c6ee072
commit 5b7447fbe4
2 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/app/plugins/shape.cljs
View File

@ -112,7 +112,7 @@
:set
(fn [_ value]
(cond
(or (not (number? value)) (not (pos? value)))
(or (not (sm/valid-safe-int? value)) (neg? value))
(u/not-valid plugin-id :delay value)
:else

27
frontend/test/frontend_tests/plugins/interactions_test.cljs
View File

@ -11,7 +11,8 @@
[app.plugins.api :as api]
[cljs.test :as t :include-macros true]
[frontend-tests.helpers.state :as ths]
[frontend-tests.helpers.wasm :as thw]))
[frontend-tests.helpers.wasm :as thw]
[potok.v2.core :as ptk]))
(defn- flows-of
"The vals of the current page flows from the store."
@ -80,3 +81,27 @@
(.addInteraction board1 "click" #js {:type "open-url" :url "https://example.com"})
(t/is (empty? (flows-of store context page))
"open-url interactions do not create a flow"))))))
(def ^:private plugin-id "00000000-0000-0000-0000-000000000000")
(defn- throws?
[thunk]
(try (thunk) false (catch :default _ true)))
(t/deftest interaction-delay-accepts-zero
;; Regression: the InteractionProxy `:delay` setter rejected 0 via
;; `(not (pos? value))`, but the model (`set-delay` -> `check-safe-int`) allows
;; 0 (an immediate after-delay interaction). With `throwValidationErrors`
;; enabled, setting 0 must NOT throw (its validation guard passes), while a
;; negative value must still be rejected.
(thw/with-wasm-mocks*
(fn []
(let [store (ths/setup-store (cthf/sample-file :file1 :page-label :page1))
^js context (api/create-context plugin-id)
_ (set! st/state store)
^js board1 (.createBoard context)
^js board2 (.createBoard context)
^js inter (.addInteraction board1 "after-delay" #js {:type "navigate-to" :destination board2} 300)]
(ptk/emit! store #(assoc-in % [:plugins :flags plugin-id :throw-validation-errors] true))
(t/is (not (throws? #(set! (.-delay inter) 0))) "delay = 0 must be accepted")
(t/is (throws? #(set! (.-delay inter) -1)) "negative delay must be rejected")))))