github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-09-13 07:30:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix error when get-parent-with-data encounters non-Element nodes

Browse Source 
The get-parent-with-data function traverses the DOM using parentElement
to find an ancestor with a specific data-* attribute. When the current
node is a non-Element DOM node (e.g. Document node reached from event
handlers on window), accessing .-dataset returns undefined, causing
obj/in? to throw "right-hand side of 'in' should be an object".

This adds a nodeType check to skip non-Element nodes during traversal
and continue up the parent chain.

Signed-off-by: Andrey Antukh <niwi@niwi.nz>
This commit is contained in:
Andrey Antukh 2026-03-23 19:19:27 +00:00
parent 2d616cf9c0
commit 577f00dd24
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/app/util/dom.cljs
View File

@ -170,8 +170,17 @@
[^js node name] [^js node name]
(let [name (str/camel name)] (let [name (str/camel name)]
(loop [current node] (loop [current node]
(if (or (nil? current) (obj/in? (.-dataset current) name)) (cond
(nil? current)
nil
(not= (.-nodeType current) js/Node.ELEMENT_NODE)
(recur (.-parentElement current))
(obj/in? (.-dataset current) name)
current current
:else
(recur (.-parentElement current)))))) (recur (.-parentElement current))))))
(defn get-parent-with-selector (defn get-parent-with-selector