github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-29 22:10:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

📎 Count only a thumbnail test's own RPC calls

Browse Source 
The clear-thumbnail-batch tests mock the RPC and count every call
recorded while the mock is installed. A thumbnail deletion batch left
over by an earlier test of the suite (a component sync clears the
thumbnails of the frames it changes) can call it in that window, so
the tests failed in the full frontend run from time to time and passed
alone.

- The batch tests count the calls about their own object ids.
- The test that clears an empty queue expected no call at all; a call
  made by the event under test could only carry no object ids, so it
  checks that none of the recorded calls is such a call.

AI-assisted-by: claude-opus-5-5

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
alonso.torres 2026-10-14 16:25:51 +02:00
parent e416a14e35
commit 53d99af5a3
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
frontend/test/frontend_tests/data/workspace_thumbnails_test.cljs
View File

@ -186,6 +186,13 @@
[file-id n]
(vec (repeatedly n #(thc/fmt-object-id file-id (uuid/next) (uuid/next) "frame"))))
(defn- calls-for
"The recorded RPC calls about the thumbnails `oids`: a batch left over by
an earlier test can call the mock while it is installed."
[oids]
(let [own? (set oids)]
(filterv #(some own? (get-in % [:params :object-ids])) @mock/rpc-calls)))
(t/deftest clear-thumbnail-batch-watch-calls-rpc-with-object-ids
(t/async
done
@ -204,8 +211,8 @@
(fn [_] nil)
(fn [err] (t/is (nil? err)) (done'))
(fn [_]
(t/is (= 1 (count @mock/rpc-calls)))
(let [[{:keys [cmd params]}] @mock/rpc-calls]
(t/is (= 1 (count (calls-for oids))))
(let [[{:keys [cmd params]}] (calls-for oids)]
(t/is (= :delete-file-object-thumbnails cmd))
(t/is (= (vec oids) (:object-ids params))))
(done')))))
@ -229,8 +236,8 @@
(fn [_] nil)
(fn [err] (t/is (nil? err)) (done'))
(fn [_]
(t/is (= 2 (count @mock/rpc-calls)))
(let [[c1 c2] @mock/rpc-calls]
(t/is (= 2 (count (calls-for oids))))
(let [[c1 c2] (calls-for oids)]
(t/is (= :delete-file-object-thumbnails (:cmd c1)))
(t/is (= :delete-file-object-thumbnails (:cmd c2)))
(t/is (= 200 (count (:object-ids (:params c1)))))
@ -282,7 +289,8 @@
(fn [_] nil)
(fn [err] (t/is (nil? err)) (done'))
(fn [_]
(t/is (empty? @mock/rpc-calls))
;; a call of this event could only carry no object ids
(t/is (not-any? #(empty? (get-in % [:params :object-ids])) @mock/rpc-calls))
(done')))))
done))))