github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-28 21:40:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

♻️ Explain layout_container's deprecated import and format visual spec (#12449)

Browse Source 
* ♻️ Explain why layout_container.scss keeps the deprecated import

The TODO at the top said to remove the refactor/ import once the buttons
were replaced, and sat above the DS imports instead of that one. The
buttons are now DS buttons (#12428, #12431), but the import is still
needed by the numeric inputs (%input-element, %disabled-input) and by the
two raw track header buttons, which keep the secondary and tertiary
placeholders. Replace the TODO with a comment on the import that says so.

AI-assisted-by: claude-opus-5-5

* 📎 Format the workspace visual spec with Prettier

Three expectations added in #12423, #12428 and #12431 broke a call chain
in a way Prettier rewrites. check-fmt:js did not catch it: its
playwright/**/*.js glob is expanded by the shell without globstar, so it
does not reach visual-specs/.

AI-assisted-by: claude-opus-5-5
This commit is contained in:
Eva Marco 2026-10-20 09:19:17 +02:00 committed by GitHub
parent 9904e50889
commit 47d7ad2de1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/playwright/ui/visual-specs/workspace.spec.js
View File

@ -71,8 +71,9 @@ test.describe("Grid layout", () => {
await workspace.clickLeafLayer("Board");
const section = page.getByTestId("inspect-layout");
await expect(section.getByRole("button", { name: "Edit grid" }))
.toBeVisible();
await expect(
section.getByRole("button", { name: "Edit grid" }),
).toBeVisible();
// The buttons are a small part of the section: compare every pixel.
await expect(section).toHaveScreenshot("grid-layout-options.png", {
maxDiffPixelRatio: 0,
@ -187,8 +188,9 @@ test.describe("Design tab", () => {
await padding.click();
await padding.blur();
await page.mouse.move(0, 0);
await expect(section.getByRole("textbox", { name: /top padding/i }))
.toBeVisible();
await expect(
section.getByRole("textbox", { name: /top padding/i }),
).toBeVisible();
await expect(section).toHaveScreenshot("flex-layout-pressed.png", {
maxDiffPixelRatio: 0,
threshold: 0,
@ -255,8 +257,9 @@ test.describe("Design tab", () => {
await marginMode.click();
await marginMode.blur();
await page.mouse.move(0, 0);
await expect(section.getByRole("textbox", { name: "Top margin" }))
.toBeVisible();
await expect(
section.getByRole("textbox", { name: "Top margin" }),
).toBeVisible();
await expect(section).toHaveScreenshot("margin-multiple.png", {
maxDiffPixelRatio: 0,
threshold: 0,

4
frontend/src/app/main/ui/workspace/sidebar/options/menus/layout_container.scss
View File

@ -4,13 +4,15 @@
//
// Copyright (c) KALEIDOS SUBSIDIARY SL
// TODO: When button replace remove this @use
@use "ds/_utils.scss" as *;
@use "ds/_sizes.scss" as *;
@use "ds/_borders.scss" as *;
@use "ds/typography.scss" as t;
@use "ds/spacing.scss" as *;
@use "ds/mixins.scss" as *;
// Only for %input-element and %disabled-input (numeric inputs) and the
// secondary and tertiary placeholders of the raw track header buttons.
@use "refactor/common-refactor.scss" as deprecated;
@use "../../../sidebar/common/sidebar.scss" as sidebar;