github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-09-14 07:59:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix unable to finish the create account form using keyboard (#8273)

Browse Source 
* 🐛 Fix unable to finish the create account form using keyboard

* 📎 Prefer dom/click over dom/click!

---------

Co-authored-by: Andrey Antukh <niwi@niwi.nz>
This commit is contained in:
Pablo Alba 2026-02-16 10:49:51 +01:00 committed by GitHub
parent a0236e8c7e
commit 43725a4abe
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGES.md
View File

@ -36,6 +36,7 @@
- Fix boolean operators in menu for boards [Taiga #13174](https://tree.taiga.io/project/penpot/issue/13174) - Fix boolean operators in menu for boards [Taiga #13174](https://tree.taiga.io/project/penpot/issue/13174)
- Fix viewer can update library [Taiga #13186](https://tree.taiga.io/project/penpot/issue/13186) - Fix viewer can update library [Taiga #13186](https://tree.taiga.io/project/penpot/issue/13186)
- Fix remove fill affects different element than selected [Taiga #13128](https://tree.taiga.io/project/penpot/issue/13128) - Fix remove fill affects different element than selected [Taiga #13128](https://tree.taiga.io/project/penpot/issue/13128)
- Fix unable to finish the create account form using keyboard [Taiga #11333](https://tree.taiga.io/project/penpot/issue/11333)
## 2.13.2 ## 2.13.2

2
frontend/src/app/main/ui/components/dropdown_menu.cljs
View File

@ -78,7 +78,7 @@
(kbd/enter? event) (kbd/enter? event)
(let [selected (dom/get-active)] (let [selected (dom/get-active)]
(dom/prevent-default event) (dom/prevent-default event)
(dom/click! selected)) (dom/click selected))
(kbd/tab? event) (kbd/tab? event)
(on-close)))))] (on-close)))))]

13
frontend/src/app/main/ui/components/forms.cljs
View File

@ -32,6 +32,7 @@
input-name (get props :name) input-name (get props :name)
more-classes (get props :class) more-classes (get props :class)
auto-focus? (get props :auto-focus? false) auto-focus? (get props :auto-focus? false)
input-ref (mf/use-ref nil)
data-testid (d/nilv data-testid input-name) data-testid (d/nilv data-testid input-name)
@ -82,7 +83,6 @@
(swap! form assoc-in [:touched input-name] true) (swap! form assoc-in [:touched input-name] true)
(fm/on-input-change form input-name value trim) (fm/on-input-change form input-name value trim)
(on-change-value name value))) (on-change-value name value)))
on-blur on-blur
(fn [_] (fn [_]
(reset! focus? false)) (reset! focus? false))
@ -92,9 +92,18 @@
(when-not (get-in @form [:touched input-name]) (when-not (get-in @form [:touched input-name])
(swap! form assoc-in [:touched input-name] true))) (swap! form assoc-in [:touched input-name] true)))
on-key-press
(mf/use-fn
(mf/deps input-ref)
(fn [e]
(dom/prevent-default e)
(when (kbd/space? e)
(dom/click (mf/ref-val input-ref)))))
props (-> props props (-> props
(dissoc :help-icon :form :trim :children :show-success? :auto-focus? :label) (dissoc :help-icon :form :trim :children :show-success? :auto-focus? :label)
(assoc :id (name input-name) (assoc :id (name input-name)
:ref input-ref
:value value :value value
:auto-focus auto-focus? :auto-focus auto-focus?
:on-click (when (or is-radio? is-checkbox?) on-click) :on-click (when (or is-radio? is-checkbox?) on-click)
@ -131,7 +140,7 @@
:for (name input-name)} label :for (name input-name)} label
(when is-checkbox? (when is-checkbox?
[:span {:class (stl/css-case :global/checked checked?)} (when checked? deprecated-icon/status-tick)]) [:span {:class (stl/css-case :global/checked checked?) :tab-index "0" :on-key-press on-key-press} (when checked? deprecated-icon/status-tick)])
(if is-checkbox? (if is-checkbox?
[:> :input props] [:> :input props]

2
frontend/src/app/main/ui/dashboard/project_menu.cljs
View File

@ -77,7 +77,7 @@
(mf/use-ref nil) (mf/use-ref nil)
on-import-files on-import-files
(fn [] (dom/click! (mf/ref-val file-input))) (fn [] (dom/click (mf/ref-val file-input)))
on-finish-import on-finish-import
(mf/use-fn (mf/use-fn

6
frontend/src/app/main/ui/dashboard/sidebar.cljs
View File

@ -530,7 +530,7 @@
(dom/prevent-default event) (dom/prevent-default event)
(dom/stop-propagation event) (dom/stop-propagation event)
(some-> (dom/get-current-target event) (some-> (dom/get-current-target event)
(dom/click!))))) (dom/click)))))
close-teams-menu close-teams-menu
(mf/use-fn #(reset! show-teams-menu* false))] (mf/use-fn #(reset! show-teams-menu* false))]
@ -601,7 +601,7 @@
(dom/prevent-default event) (dom/prevent-default event)
(dom/stop-propagation event) (dom/stop-propagation event)
(some-> (dom/get-current-target event) (some-> (dom/get-current-target event)
(dom/click!))))) (dom/click)))))
close-team-options-menu close-team-options-menu
(mf/use-fn #(reset! show-team-options-menu* false)) (mf/use-fn #(reset! show-team-options-menu* false))
@ -621,7 +621,7 @@
(dom/stop-propagation event) (dom/stop-propagation event)
(some-> (dom/get-current-target event) (some-> (dom/get-current-target event)
(dom/click!))))) (dom/click)))))
close-teams-menu close-teams-menu
(mf/use-fn #(reset! show-teams-menu* false))] (mf/use-fn #(reset! show-teams-menu* false))]

8
frontend/src/app/util/dom.cljs
View File

@ -230,12 +230,6 @@
(def get-target-scroll (comp get-scroll-position get-target)) (def get-target-scroll (comp get-scroll-position get-target))
(defn click
"Click a node"
[^js node]
(when (some? node)
(.click node)))
(defn get-files (defn get-files
"Extract the files from dom node." "Extract the files from dom node."
[^js node] [^js node]
@ -476,7 +470,7 @@
(when (some? node) (when (some? node)
(.focus node))) (.focus node)))
(defn click! (defn click
[^js node] [^js node]
(when (some? node) (when (some? node)
(.click node))) (.click node)))