github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-05-28 19:33:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix empty values should not have dimmed text (#7015)

Browse Source
This commit is contained in:
luisδμ 2025-07-30 18:06:39 +02:00 committed by GitHub
parent 4d688b1d55
commit 3b04cd37ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/app/main/ui/ds/controls/shared/options_dropdown.cljs
View File

@ -49,7 +49,7 @@
(mf/defc option* (mf/defc option*
{::mf/private true} {::mf/private true}
[{:keys [id ref label icon aria-label on-click selected focused dimmed] :rest props}] [{:keys [id ref label icon aria-label on-click selected focused] :rest props}]
(let [class (stl/css-case :option true (let [class (stl/css-case :option true
:option-with-icon (some? icon) :option-with-icon (some? icon)
:option-selected selected :option-selected selected
@ -72,9 +72,7 @@
:aria-hidden (when label true) :aria-hidden (when label true)
:aria-label (when (not label) aria-label)}]) :aria-label (when (not label) aria-label)}])
[:span {:class (stl/css-case :option-text true [:span {:class (stl/css :option-text)} label]
:option-text-dimmed dimmed)}
label]
(when selected (when selected
[:> i/icon* [:> i/icon*
@ -117,7 +115,6 @@
:aria-label aria-label :aria-label aria-label
:ref ref :ref ref
:focused (= id focused) :focused (= id focused)
:dimmed false
:on-click on-click}])) :on-click on-click}]))
(when (seq options-blank) (when (seq options-blank)
@ -138,5 +135,4 @@
:aria-label aria-label :aria-label aria-label
:ref ref :ref ref
:focused (= id focused) :focused (= id focused)
:dimmed true
:on-click on-click}]))])])) :on-click on-click}]))])]))

4
frontend/src/app/main/ui/ds/controls/shared/options_dropdown.scss
View File

@ -67,10 +67,6 @@
padding-inline-start: var(--sp-xxs); padding-inline-start: var(--sp-xxs);
} }
.option-text-dimmed {
color: var(--options-dropdown-empty);
}
.option-icon { .option-icon {
color: var(--options-dropdown-icon-fg-color); color: var(--options-dropdown-icon-fg-color);
} }