From 3716989e270b66f13761397d48632dfdefef4f67 Mon Sep 17 00:00:00 2001 From: Miguel de Benito Delgado Date: Fri, 6 Nov 2026 13:40:46 +0100 Subject: [PATCH] :lipstick: Prefer shorter form lambdas in obvious places --- .../benches/render_wasm/browser/bridge.cljs | 15 +++++-------- .../benches/render_wasm/builder.cljc | 3 +-- .../benches/render_wasm/cases.cljs | 5 ++--- .../benches/render_wasm/declarations.cljc | 7 +++--- .../benches/render_wasm/node/process.cljs | 4 +--- .../node/runner/feature_comparison.cljs | 22 +++++++++---------- .../benches/render_wasm/result.cljs | 15 ++++++------- .../benches/render_wasm/runtime/camera.cljs | 14 +++++------- 8 files changed, 35 insertions(+), 50 deletions(-) diff --git a/frontend/performance/benches/render_wasm/browser/bridge.cljs b/frontend/performance/benches/render_wasm/browser/bridge.cljs index 3c356d3204..e295f05a8e 100644 --- a/frontend/performance/benches/render_wasm/browser/bridge.cljs +++ b/frontend/performance/benches/render_wasm/browser/bridge.cljs @@ -337,9 +337,8 @@ and `:software` identity fields." [ctx width height dpr renderer] (let [attrs (ex/ignoring (.getContextAttributes ^js ctx)) - attr (fn [k] - (when (some? attrs) - (unchecked-get attrs k))) + attr #(when (some? attrs) + (unchecked-get attrs %)) vendor (graphics-string ctx "UNMASKED_VENDOR_WEBGL")] {:css-width width :css-height height @@ -610,11 +609,9 @@ [epoch params] (-> (ensure-module! (or (:module-url params) "./render-wasm.js") (or (:wasm-url params) "./render-wasm.wasm")) - (.catch (fn [cause] - (throw (ex-info (str "module init failed: " - (or (ex-message cause) cause)) - {:phase "module-init"} - cause)))) + (.catch #(throw (ex-info (str "module init failed: " (or (ex-message %) %)) + {:phase "module-init"} + %))) (.then (fn [installed] (guard-current! epoch "module-init") installed)))) @@ -1042,7 +1039,7 @@ (when (= epoch @owner-epoch*) (swap! prepared* assoc :busy? false)) evidence)) - (.catch (fn [cause] (terminal-failure epoch cause "attempt")))))))) + (.catch #(terminal-failure epoch % "attempt"))))))) (defn- encode-evidence "Encodes bridge evidence after timing and resolves failures as bridge diff --git a/frontend/performance/benches/render_wasm/builder.cljc b/frontend/performance/benches/render_wasm/builder.cljc index 20a7beb36b..3f7c35431b 100644 --- a/frontend/performance/benches/render_wasm/builder.cljc +++ b/frontend/performance/benches/render_wasm/builder.cljc @@ -278,8 +278,7 @@ (let [{:keys [id frame-id]} *parent*] (register-ref! state label (:id shape)) (swap! state - (fn [scope] - (ctst/add-shape (:id shape) shape scope frame-id id nil true))))) + #(ctst/add-shape (:id shape) shape % frame-id id nil true)))) ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; Shape constructors diff --git a/frontend/performance/benches/render_wasm/cases.cljs b/frontend/performance/benches/render_wasm/cases.cljs index e995554bae..f67962538e 100644 --- a/frontend/performance/benches/render_wasm/cases.cljs +++ b/frontend/performance/benches/render_wasm/cases.cljs @@ -118,9 +118,8 @@ (decl/check-registered-scene! scene)) (let [selected (->> (decl/cases) (map #(validate-case! % scene-by-id)) - (filter (fn [registered] - (or (str/blank? pattern) - (str/includes? (str (:id registered)) pattern)))) + (filter #(or (str/blank? pattern) + (str/includes? (str (:id %)) pattern))) (mapv #(describe-case master-seed % (get scene-by-id (:scene %)))))] (when (empty? selected) (throw (ex-info "no benchmark cases match the selection" diff --git a/frontend/performance/benches/render_wasm/declarations.cljc b/frontend/performance/benches/render_wasm/declarations.cljc index 1c59d30f6e..5a131e825e 100644 --- a/frontend/performance/benches/render_wasm/declarations.cljc +++ b/frontend/performance/benches/render_wasm/declarations.cljc @@ -187,10 +187,9 @@ :ns ns :existing-ns (:ns existing)}))) (swap! registry - (fn [reg] - (cond-> (assoc-in reg [entries-key id] entry) - (not (contains? (get reg entries-key) id)) - (update order-key conj id))))) + #(cond-> (assoc-in % [entries-key id] entry) + (not (contains? (get % entries-key) id)) + (update order-key conj id)))) id) (defn register-scene! diff --git a/frontend/performance/benches/render_wasm/node/process.cljs b/frontend/performance/benches/render_wasm/node/process.cljs index 57f5798a0a..53d2b5218a 100644 --- a/frontend/performance/benches/render_wasm/node/process.cljs +++ b/frontend/performance/benches/render_wasm/node/process.cljs @@ -175,9 +175,7 @@ (.once child "exit" (fn [code signal] (resolve {:exit-code code :signal signal}))) - (.once child "error" - (fn [cause] - (resolve (spawn-failed cause))))))] + (.once child "error" #(resolve (spawn-failed %)))))] (try (if-not (.-pid child) ;; A failed spawn may not provide stdin/stdout/stderr at all. diff --git a/frontend/performance/benches/render_wasm/node/runner/feature_comparison.cljs b/frontend/performance/benches/render_wasm/node/runner/feature_comparison.cljs index a8138e60c3..4700be121f 100644 --- a/frontend/performance/benches/render_wasm/node/runner/feature_comparison.cljs +++ b/frontend/performance/benches/render_wasm/node/runner/feature_comparison.cljs @@ -117,22 +117,20 @@ (defn- change-config [record slug f] (update record :configurations - (fn [configurations] - (mapv (fn [configuration] - (if (= slug (:slug configuration)) - (f configuration) - configuration)) - configurations)))) + #(mapv (fn [config] + (if (= slug (:slug config)) + (f config) + config)) + %))) (defn- change-edge [record from to f] (update record :edges - (fn [edges] - (mapv (fn [edge] - (if (and (= from (:from edge)) (= to (:to edge))) - (f edge) - edge)) - edges)))) + #(mapv (fn [edge] + (if (and (= from (:from edge)) (= to (:to edge))) + (f edge) + edge)) + %))) (defn- config-by-slug [record slug] diff --git a/frontend/performance/benches/render_wasm/result.cljs b/frontend/performance/benches/render_wasm/result.cljs index 249f223c08..5fd87b64d4 100644 --- a/frontend/performance/benches/render_wasm/result.cljs +++ b/frontend/performance/benches/render_wasm/result.cljs @@ -561,14 +561,13 @@ additional-end base-end))) metadata (update (:metadata base) :diagnostics - (fn [diagnostics] - (assoc (or diagnostics {}) - :merge - {:base-run-id (:run-id base) - :additional-run-id (:run-id additional) - :additional-warmups-excluded - (count (filter :warmup? (:attempts additional))) - :merged-at ended-at})))] + #(assoc (or % {}) + :merge + {:base-run-id (:run-id base) + :additional-run-id (:run-id additional) + :additional-warmups-excluded + (count (filter :warmup? (:attempts additional))) + :merged-at ended-at}))] (check-run {:type :run-record :run-id run-id :started-at (:started-at base) diff --git a/frontend/performance/benches/render_wasm/runtime/camera.cljs b/frontend/performance/benches/render_wasm/runtime/camera.cljs index dec26b01ae..cc334fe604 100644 --- a/frontend/performance/benches/render_wasm/runtime/camera.cljs +++ b/frontend/performance/benches/render_wasm/runtime/camera.cljs @@ -96,8 +96,7 @@ {:pre [(valid-pan? options) (valid-view? (pan-view (:view rtx) dx dy))]} (let [target (pan-view (:view rtx) dx dy)] (-> (run-camera rtx target options) - (.then (fn [evidence] - (complete (assoc rtx :view target) (camera-evidence evidence)))) + (.then #(complete (assoc rtx :view target) (camera-evidence %))) (.catch fail)))) (defcommand load @@ -113,9 +112,8 @@ [rtx] (let [hooks (:hooks rtx)] (-> (protocol/drain hooks {:flags 0 :origin ((:now hooks)) :immediate false}) - (.then (fn [evidence] - (complete rtx (assoc-in (render-evidence evidence) - [:metrics :renderer/prepared-scene-to-full] [(:full-ms evidence)])))) + (.then #(complete rtx (assoc-in (render-evidence %) + [:metrics :renderer/prepared-scene-to-full] [(:full-ms %)]))) (.catch fail)))) (defcommand zoom @@ -132,8 +130,7 @@ {:pre [(valid-zoom? options) (valid-view? (zoom-view (:view rtx) factor))]} (let [target (zoom-view (:view rtx) factor)] (-> (run-camera rtx target options) - (.then (fn [evidence] - (complete (assoc rtx :view target) (camera-evidence evidence)))) + (.then #(complete (assoc rtx :view target) (camera-evidence %))) (.catch fail)))) (defcommand restore @@ -150,6 +147,5 @@ {:pre [(valid-view? view) (= (decl/resolve-viewport view) (decl/resolve-viewport (:view rtx)))]} (-> (protocol/restore (:hooks rtx) view) - (.then (fn [evidence] - (complete (assoc rtx :view view) (render-evidence evidence)))) + (.then #(complete (assoc rtx :view view) (render-evidence %))) (.catch fail)))