From 32d974aa3eb3349bfa5912285b2ebb98ee7d0a17 Mon Sep 17 00:00:00 2001 From: Dexterity <173429049+Dexterity104@users.noreply.github.com> Date: Wed, 10 Jun 2026 04:51:35 -0400 Subject: [PATCH] :recycle: Migrate onboarding team-choice to modern component syntax (#9463) Co-authored-by: Andrey Antukh --- frontend/src/app/main/ui.cljs | 8 ++++---- .../src/app/main/ui/onboarding/team_choice.cljs | 17 +++++++---------- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/frontend/src/app/main/ui.cljs b/frontend/src/app/main/ui.cljs index 5d95652b1d..157ae24d9b 100644 --- a/frontend/src/app/main/ui.cljs +++ b/frontend/src/app/main/ui.cljs @@ -27,7 +27,7 @@ [app.main.ui.nitrate.entry :as nitrate-entry] [app.main.ui.notifications :as notifications] [app.main.ui.onboarding.questions :refer [questions-modal]] - [app.main.ui.onboarding.team-choice :refer [onboarding-team-modal]] + [app.main.ui.onboarding.team-choice :refer [onboarding-team-modal*]] [app.main.ui.releases :refer [release-notes-modal]] [app.main.ui.static :as static] [app.util.dom :as dom] @@ -238,14 +238,14 @@ #_[:& app.main.ui.releases/release-notes-modal {:version "2.5"}] #_[:& app.main.ui.onboarding/onboarding-templates-modal] #_[:& app.main.ui.onboarding/onboarding-modal] - #_[:& app.main.ui.onboarding.team-choice/onboarding-team-modal] + #_[:> app.main.ui.onboarding.team-choice/onboarding-team-modal*] (cond show-question-modal? [:& questions-modal] show-team-modal? - [:& onboarding-team-modal {:go-to-team true}] + [:> onboarding-team-modal* {:go-to-team true}] show-release-modal? [:& release-notes-modal {:version (:main cf/version)}]) @@ -272,7 +272,7 @@ [:& questions-modal] show-team-modal? - [:& onboarding-team-modal {:go-to-team false}] + [:> onboarding-team-modal* {:go-to-team false}] show-release-modal? [:& release-notes-modal {:version (:main cf/version)}])) diff --git a/frontend/src/app/main/ui/onboarding/team_choice.cljs b/frontend/src/app/main/ui/onboarding/team_choice.cljs index 65cb48546a..af457b2dd3 100644 --- a/frontend/src/app/main/ui/onboarding/team_choice.cljs +++ b/frontend/src/app/main/ui/onboarding/team_choice.cljs @@ -20,9 +20,8 @@ [app.util.i18n :as i18n :refer [tr]] [rumext.v2 :as mf])) -(mf/defc left-sidebar - {::mf/props :obj - ::mf/private true} +(mf/defc left-sidebar* + {::mf/private true} [] [:div {:class (stl/css :modal-left)} [:h2 {:class (stl/css :modal-subtitle)} @@ -63,9 +62,8 @@ [:role :keyword] [:emails {:optional true} [::sm/set ::sm/email]]]) -(mf/defc team-form - {::mf/props :obj - ::mf/private true} +(mf/defc team-form* + {::mf/private true} [{:keys [go-to-team]}] (let [initial (mf/with-memo [] {:role "editor"}) @@ -228,8 +226,7 @@ :on-click on-skip} (tr "onboarding.choice.team-up.continue-without-a-team")]]]]])) -(mf/defc onboarding-team-modal - {::mf/props :obj} +(mf/defc onboarding-team-modal* [{:keys [go-to-team]}] [:div {:class (stl/css-case @@ -239,7 +236,7 @@ [:h1 {:class (stl/css :modal-title)} (tr "onboarding-v2.welcome.title")] [:div {:class (stl/css :modal-sections)} - [:& left-sidebar] + [:> left-sidebar*] [:div {:class (stl/css :separator)}] - [:& team-form {:go-to-team go-to-team}]]]]) + [:> team-form* {:go-to-team go-to-team}]]]])