From 32a1de9fe8541b3679e7866a46bcac08ea1c7f5c Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Wed, 22 Apr 2026 22:05:13 +0000 Subject: [PATCH] :bug: Filter non-http(s) URLs in upload-images to prevent invalid calls Skip upload for image items that are not data URIs and do not have an http:// or https:// URL, avoiding unnecessary RPC calls with invalid URLs to create-file-media-object-from-url. Signed-off-by: Andrey Antukh --- frontend/src/app/main/data/workspace/svg_upload.cljs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/frontend/src/app/main/data/workspace/svg_upload.cljs b/frontend/src/app/main/data/workspace/svg_upload.cljs index a573cd594b..265c31b0b2 100644 --- a/frontend/src/app/main/data/workspace/svg_upload.cljs +++ b/frontend/src/app/main/data/workspace/svg_upload.cljs @@ -47,10 +47,12 @@ (-> item (assoc :name (extract-name href)) (assoc :url href)))))) + (rx/filter (fn [item] + (or (contains? item :content) + (let [url (:url item)] + (or (str/starts-with? url "http://") + (str/starts-with? url "https://")))))) (rx/mapcat (fn [item] - ;; TODO: :create-file-media-object-from-url is - ;; deprecated and this should be resolved in - ;; frontend (->> (rp/cmd! (if (contains? item :content) :upload-file-media-object :create-file-media-object-from-url)