github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-08-19 03:08:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Add concurrency limit to import-binfile RPC handler (#11024)

Browse Source 
Apply climit with 4 global permits and 1 per-profile permit (queue 2)
to prevent connection pool exhaustion from concurrent imports. Each
import holds a DB connection for its entire duration with idle
transaction timeout disabled, so unbounded concurrency could exhaust
the pool (default 60 connections).

AI-assisted-by: mimo-v2.5-pro
This commit is contained in:
Andrey Antukh 2026-08-17 11:08:07 +02:00 committed by GitHub
parent aecfee0f02
commit 3033da4409
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
backend/resources/climit.edn
View File

@ -45,4 +45,10 @@
{:permits 4} {:permits 4}
:send-user-feedback/by-profile :send-user-feedback/by-profile
{:permits 1 :queue 3}} {:permits 1 :queue 3}
:import-binfile/global
{:permits 4}
:import-binfile/by-profile
{:permits 1 :queue 2}}

5
backend/src/app/rpc/commands/binfile.clj
View File

@ -21,6 +21,7 @@
[app.loggers.webhooks :as-alias webhooks] [app.loggers.webhooks :as-alias webhooks]
[app.media.validation :as media.v] [app.media.validation :as media.v]
[app.rpc :as-alias rpc] [app.rpc :as-alias rpc]
[app.rpc.climit :as-alias climit]
[app.rpc.commands.files :as files] [app.rpc.commands.files :as files]
[app.rpc.commands.media :as media-cmd] [app.rpc.commands.media :as media-cmd]
[app.rpc.commands.projects :as projects] [app.rpc.commands.projects :as projects]
@ -142,7 +143,9 @@
::webhooks/event? true ::webhooks/event? true
::sse/stream? true ::sse/stream? true
::sm/params schema:import-binfile} ::sm/params schema:import-binfile
::climit/id [[:import-binfile/by-profile ::rpc/profile-id]
[:import-binfile/global]]}
[{:keys [::db/pool] :as cfg} {:keys [::rpc/profile-id project-id version upload-id] :as params}] [{:keys [::db/pool] :as cfg} {:keys [::rpc/profile-id project-id version upload-id] :as params}]
(projects/check-edition-permissions! pool profile-id project-id) (projects/check-edition-permissions! pool profile-id project-id)
(let [version (or version 3) (let [version (or version 3)