github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-07-22 14:08:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix problem with rotations crashing (#10560)

Browse Source
This commit is contained in:
Alonso Torres 2026-07-06 11:56:46 +02:00 committed by GitHub
parent e5d3ea14d1
commit 2dfb1046f7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
frontend/src/app/main/constants.cljs
View File

@ -329,3 +329,15 @@
;; ------------------------------------------------
(def ^:const selection-rect-width 1)
;; ------------------------------------------------
;; Transform preview sampling
;; ------------------------------------------------
(def ^:const default-sample-time
"Default time in ms for the sampling of transforms, this caps to one per frame the preview of modifiers"
16)
(def ^:const resize-sample-time default-sample-time)
(def ^:const rotation-sample-time default-sample-time)
(def ^:const move-sample-time default-sample-time)

11
frontend/src/app/main/data/workspace/transforms.cljs
View File

@ -27,6 +27,7 @@
[app.common.types.shape.attrs :refer [editable-attrs]]
[app.common.types.shape.layout :as ctl]
[app.common.uuid :as uuid]
[app.main.constants :as mconst]
[app.main.data.changes :as dch]
[app.main.data.event :as ev]
[app.main.data.helpers :as dsh]
@ -308,6 +309,7 @@
(if (features/active-feature? state "render-wasm/v1")
(rx/merge
(->> resize-events-stream
(rx/sample mconst/resize-sample-time)
(rx/mapcat
(fn [modifiers]
(let [modif-tree (dwm/create-modif-tree shape-ids modifiers)]
@ -335,7 +337,7 @@
;; rx/last applies the exact final frame.
(rx/merge
(->> resize-events-stream
(rx/sample 16)
(rx/sample mconst/resize-sample-time)
(rx/mapcat emit-modifiers)
(rx/take-until stopper))
(->> resize-events-stream
@ -523,6 +525,7 @@
(rx/concat
(rx/merge
(->> angle-stream
(rx/sample mconst/rotation-sample-time)
(rx/map #(dwm/set-wasm-modifiers (rotation-modifiers % shapes group-center)))
(rx/take-until stopper))
(->> angle-stream
@ -539,7 +542,7 @@
(rx/concat
(rx/merge
(->> angle-stream
(rx/sample 16)
(rx/sample mconst/rotation-sample-time)
(rx/map emit-modifiers)
(rx/take-until stopper))
(->> angle-stream
@ -800,7 +803,7 @@
(rx/take-until duplicate-stopper)
;; Sample at a fixed cadence to keep preview smooth. Unlike a throttle,
;; this tends to avoid perceptible "jumps" while still capping WASM work.
(rx/sample 16)
(rx/sample mconst/move-sample-time)
(rx/map
(fn [[modifiers snap-ignore-axis]]
(dwm/set-wasm-modifiers modifiers
@ -840,7 +843,7 @@
(rx/merge
(->> modifiers-stream
;; Throttle the live preview to limit re-renders.
(rx/sample 16)
(rx/sample mconst/move-sample-time)
(rx/map
(fn [[modifiers snap-ignore-axis]]
(dwm/set-modifiers modifiers false false {:snap-ignore-axis snap-ignore-axis}))))