github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-29 22:10:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

✨ Publish the size limits so the UI can state them before a refusal

Browse Source
This commit is contained in:
Álvaro Tejero Cantero 2026-08-14 08:25:56 +02:00
parent fcaf1945fe
commit 264f1e930c
No known key found for this signature in database
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
backend/src/app/rpc/commands/files_branch.clj
View File

@ -129,6 +129,21 @@
:actual depth))
changes))
(def ^:private schema:get-branching-limits
[:map {:title "get-branching-limits"}])
(sv/defmethod ::get-branching-limits
"The size limits this instance refuses beyond, so the UI can publish them
before a user meets one. Read from config on every call: the limits have
exactly one home, and a page that states them must not keep its own copy."
{::doc/added "2.16"
::sm/params schema:get-branching-limits}
[_cfg _params]
(check-branching-enabled!)
{:max-shapes (branching-limit :branching-max-shapes 50000)
:max-pages (branching-limit :branching-max-pages 500)
:max-oplog-changes (branching-limit :branching-max-oplog-changes 100000)})
;; --- Audit: what an operation cost and how it ended
;;
;; The generic RPC audit event records who called what with which params.

22
backend/test/backend_tests/rpc_file_branch_test.clj
View File

@ -1200,6 +1200,28 @@
(t/is (= 1 (:actual data)))
(t/is (str/includes? (:hint data) "materialise")))))))))
(t/deftest published-limits-are-the-ones-the-gates-enforce
(let [profile (th/create-profile* 1 {:is-active true})
limits (fn [] (th/command! {::th/type :get-branching-limits
::rpc/profile-id (:id profile)}))]
(t/testing "the defaults are published"
(with-redefs [cf/flags (conj cf/flags :branching)]
(let [out (limits)]
(t/is (nil? (:error out)))
(t/is (= {:max-shapes 50000 :max-pages 500 :max-oplog-changes 100000}
(:result out))))))
(t/testing "and they are read from config, not from the page"
(with-redefs [cf/flags (conj cf/flags :branching)
cf/get (th/config-get-mock {:branching-max-shapes 7})]
(t/is (= 7 (-> (limits) :result :max-shapes)))))
(t/testing "the query is gated like every other branching command"
(let [data (ex-data (:error (limits)))]
(t/is (= :restriction (:type data)))
(t/is (= :branching-disabled (:code data)))))))
(t/deftest branch-operations-record-duration-and-outcome
(with-redefs [cf/flags (conj cf/flags :branching)]
(let [profile (th/create-profile* 1 {:is-active true})