From 2573908315996adc597b85bcc69c1c6b23359da1 Mon Sep 17 00:00:00 2001
From: Luke Lau <luke_lau@icloud.com>
Date: Wed, 4 Nov 2026 20:00:24 +0800
Subject: [PATCH] :zap: Drop unused used-names sets from component duplication
 (#12809)

unames or update-unames! are no longer used after a1a3d09998, and each call to
cfh/get-used-names is a scan across all objects
---
 common/src/app/common/logic/libraries.cljc | 16 +++++-----------
 common/src/app/common/types/container.cljc |  4 ----
 2 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/common/src/app/common/logic/libraries.cljc b/common/src/app/common/logic/libraries.cljc
index a7296ff5d5..1b7f2488f0 100644
--- a/common/src/app/common/logic/libraries.cljc
+++ b/common/src/app/common/logic/libraries.cljc
@@ -3122,12 +3122,12 @@
     changes))
 
 (defn generate-duplicate-shape-change
-  ([changes objects page unames update-unames! ids ids-map obj delta level-delta libraries library-data file-id]
-   (generate-duplicate-shape-change changes objects page unames update-unames! ids ids-map obj delta level-delta libraries library-data file-id (:frame-id obj) (:parent-id obj) false false true nil))
-  ([changes objects page unames update-unames! ids ids-map obj delta level-delta libraries library-data file-id variant-props]
-   (generate-duplicate-shape-change changes objects page unames update-unames! ids ids-map obj delta level-delta libraries library-data file-id (:frame-id obj) (:parent-id obj) false false true variant-props))
+  ([changes objects page ids ids-map obj delta level-delta libraries library-data file-id]
+   (generate-duplicate-shape-change changes objects page ids ids-map obj delta level-delta libraries library-data file-id (:frame-id obj) (:parent-id obj) false false true nil))
+  ([changes objects page ids ids-map obj delta level-delta libraries library-data file-id variant-props]
+   (generate-duplicate-shape-change changes objects page ids ids-map obj delta level-delta libraries library-data file-id (:frame-id obj) (:parent-id obj) false false true variant-props))
 
-  ([changes objects page unames update-unames! ids ids-map obj delta level-delta libraries library-data file-id frame-id parent-id duplicating-component? child? remove-swap-slot? variant-props]
+  ([changes objects page ids ids-map obj delta level-delta libraries library-data file-id frame-id parent-id duplicating-component? child? remove-swap-slot? variant-props]
    (cond
      (nil? obj)
      changes
@@ -3240,8 +3240,6 @@
                  (generate-duplicate-shape-change changes
                                                   (:objects page')
                                                   page
-                                                  unames
-                                                  update-unames!
                                                   ids
                                                   ids-map
                                                   child
@@ -3268,8 +3266,6 @@
   move to the desired position, and recalculate parents and frames as needed."
   [changes all-objects page ids delta libraries library-data file-id & {:keys [variant-props alt-duplication?]}]
   (let [shapes         (map (d/getf all-objects) ids)
-        unames         (volatile! (cfh/get-used-names (:objects page)))
-        update-unames! (fn [new-name] (vswap! unames conj new-name))
         all-ids        (reduce #(into %1 (cons %2 (cfh/get-children-ids all-objects %2))) (d/ordered-set) ids)
 
         ;; We need ids-map for remapping the grid layout. But when duplicating the guides
@@ -3299,8 +3295,6 @@
              (reduce #(generate-duplicate-shape-change %1
                                                        all-objects
                                                        page
-                                                       unames
-                                                       update-unames!
                                                        ids
                                                        ids-map
                                                        %2
diff --git a/common/src/app/common/types/container.cljc b/common/src/app/common/types/container.cljc
index cc7ea9bd07..6f5bde52a7 100644
--- a/common/src/app/common/types/container.cljc
+++ b/common/src/app/common/types/container.cljc
@@ -324,7 +324,6 @@
          delta           (gpt/subtract position orig-pos)
 
          objects         (:objects page)
-         unames          (volatile! (cfh/get-used-names objects))
 
          component-children
          (d/index-by :id (cfh/get-children-with-self objects (:id component-shape)))
@@ -353,9 +352,6 @@
            (let [new-name (:name new-shape)
                  root?    (ctk/instance-root? original-shape)]
 
-             (when root?
-               (vswap! unames conj new-name))
-
              (vswap! ids-map assoc (:id original-shape) (:id new-shape))
 
              (cond-> new-shape