github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-05-09 18:18:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Fix crash dragging external component into a variant without props (#7111)

Browse Source
This commit is contained in:
Pablo Alba 2025-08-13 14:29:56 +02:00 committed by GitHub
parent d99ef29152
commit 2562d70880
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
common/src/app/common/logic/variant_properties.cljc
View File

@ -172,6 +172,10 @@
objects (pcb/get-objects changes)
variant-id (:id variant-container)
num-shapes (->> variant-container
:shapes
count)
;; If we are cut-pasting a variant-container, this will be null
;; because it hasn't any shapes yet
first-comp-id (->> variant-container
@ -198,7 +202,7 @@
0
shapes)
num-new-props (if (or (zero? num-base-props)
num-new-props (if (or (zero? num-shapes)
(< total-props num-base-props))
0
(- total-props num-base-props))
@ -213,7 +217,7 @@
(reduce
(fn [changes shape]
(let [component (ctcl/get-component data (:component-id shape) true)]
(if (or (zero? num-base-props) ;; do nothing if there are no base props
(if (or (zero? num-shapes) ;; do nothing if there are no shapes
(and (= variant-id (:variant-id shape)) ;; or we are only moving the shape inside its parent (it is
(not (:deleted component)))) ;; the same parent and the component isn't deleted)
changes