github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-05-30 04:08:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #9745 from penpot/superalex-fix-numeric-input-unmount

Browse Source 
🐛 Fix commit pending numeric input on unmount without blur side effects
This commit is contained in:
Alejandro Alonso 2026-05-19 16:59:55 +02:00 committed by GitHub
commit 20c6da2138
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
frontend/src/app/main/ui/ds/controls/numeric_input.cljs
View File

@ -332,6 +332,7 @@
(fn [event] (fn [event]
(let [text (dom/get-target-val event)] (let [text (dom/get-target-val event)]
(mf/set-ref-val! raw-value* text) (mf/set-ref-val! raw-value* text)
(mf/set-ref-val! dirty-ref true)
(reset! filter-id* text)))) (reset! filter-id* text))))
on-token-apply on-token-apply
@ -389,12 +390,21 @@
(reset! is-open* false))) (reset! is-open* false)))
(when (mf/ref-val dirty-ref) (when (mf/ref-val dirty-ref)
(apply-value (mf/ref-val raw-value*))) (apply-value (mf/ref-val raw-value*))
(mf/set-ref-val! dirty-ref false))
(when (fn? on-blur) (when (fn? on-blur)
(on-blur event)) (on-blur event))
(dom/blur! (mf/ref-val ref)))) (dom/blur! (mf/ref-val ref))))
handle-unmount (h/use-ref-callback handle-blur) commit-pending-on-unmount
(mf/use-fn
(mf/deps apply-value)
(fn []
(when (mf/ref-val dirty-ref)
(apply-value (mf/ref-val raw-value*))
(mf/set-ref-val! dirty-ref false))))
handle-unmount (h/use-ref-callback commit-pending-on-unmount)
on-key-down on-key-down
(mf/use-fn (mf/use-fn