github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-04-25 11:18:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

⚡ Extract on-name-input-focus as namespace-level private function

Browse Source 
The callback had no dependencies on component-local state or props,
making it a pure function that can be hoisted to a defn-. This avoids
recreating the same callback identity on every render of version-entry*.
This commit is contained in:
Andrey Antukh 2026-04-23 16:35:44 +00:00
parent c1f587d0da
commit 17b217cfb4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/app/main/ui/workspace/sidebar/versions.cljs
View File

@ -77,6 +77,10 @@
(assoc item :index index))) (assoc item :index index)))
(reverse))) (reverse)))
(defn- on-name-input-focus
[event]
(dom/select-text! (dom/get-target event)))
(mf/defc version-entry* (mf/defc version-entry*
{::mf/private true} {::mf/private true}
[{:keys [entry current-profile on-preview on-restore on-delete on-rename on-lock on-unlock on-edit on-cancel-edit is-editing]}] [{:keys [entry current-profile on-preview on-restore on-delete on-rename on-lock on-unlock on-edit on-cancel-edit is-editing]}]
@ -132,11 +136,6 @@
(when on-unlock (when on-unlock
(on-unlock (:id entry))))) (on-unlock (:id entry)))))
on-name-input-focus
(mf/use-fn
(fn [event]
(dom/select-text! (dom/get-target event))))
on-name-input-blur on-name-input-blur
(mf/use-fn (mf/use-fn
(mf/deps entry on-rename on-cancel-edit) (mf/deps entry on-rename on-cancel-edit)