github/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2026-10-29 14:00:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

🐛 Pass a JS array to family-uuid in its roundtrip test

Browse Source 
`aget` on a clj vector reads `undefined`, which the u32 setter
coerces to zero: the quartet never reached `from-unsigned-parts`,
so the test pinned zeroes and blamed `common`. Bisected down to
the raw impl (correct), the adapter takes a JS array per contract.

AI-assisted-by: muse-spark-1.3-contributor
This commit is contained in:
Andrey Antukh 2026-10-09 12:28:17 +00:00
parent 46cf000635
commit 1712d8f2c2
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
exporter/test/exporter_tests/exporter_wasm_render_test.cljs
View File

@ -49,19 +49,13 @@
"style degrades before weight")
(t/is (nil? (render/find-variant variants "f9" 400 0)))))
(t/deftest family-uuid-delegates-to-the-shared-quartets
;; `family-uuid` is a one-line adapter over `app.common.uuid`: the
;; roundtrip itself belongs to `common`, not to this pipeline, so
;; this only pins that the adapter passes the quartet through in
;; order (a probing session showed `from-unsigned-parts` answering
;; zeroes in this bundle — suspected pre-existing `common` issue,
;; flagged separately, never worked around here).
(let [seen (atom nil)]
(with-redefs [uuid/from-unsigned-parts (fn [a b c d]
(reset! seen [a b c d])
:uuid)]
(t/is (= :uuid (render/family-uuid #js [11 22 33 44])))
(t/is (= [11 22 33 44] @seen)))))
(t/deftest family-uuid-roundtrips-through-u32
;; `:id` is a JS array (never a clj vector: `aget` on a vector
;; reads `undefined`, which the u32 setter coerces to zero).
(let [id (uuid/next)
quart (uuid/get-u32 id)]
(t/is (= id (render/family-uuid #js [(aget quart 0) (aget quart 1)
(aget quart 2) (aget quart 3)])))))
(t/deftest scene-fallback-fonts-covers-emoji
(let [text-shape (fn [text]