From 1194e4022272279ed71846da4bed631c0873f0f8 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Tue, 22 Apr 2025 21:39:57 +0200 Subject: [PATCH] :bug: Properly dispose rx subscription on grid thumbnail component --- frontend/src/app/main/ui/dashboard/grid.cljs | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/src/app/main/ui/dashboard/grid.cljs b/frontend/src/app/main/ui/dashboard/grid.cljs index a8e731ff1c..450bcd0f33 100644 --- a/frontend/src/app/main/ui/dashboard/grid.cljs +++ b/frontend/src/app/main/ui/dashboard/grid.cljs @@ -89,14 +89,16 @@ (mf/with-effect [file-id revn visible? thumbnail-id] (when (and visible? (not thumbnail-id)) - (->> (ask-for-thumbnail file-id revn) - (rx/subs! (fn [thumbnail-id] - (st/emit! (dd/set-file-thumbnail file-id thumbnail-id))) - (fn [cause] - (log/error :hint "unable to render thumbnail" - :file-if file-id - :revn revn - :message (ex-message cause))))))) + (let [subscription + (->> (ask-for-thumbnail file-id revn) + (rx/subs! (fn [thumbnail-id] + (st/emit! (dd/set-file-thumbnail file-id thumbnail-id))) + (fn [cause] + (log/error :hint "unable to render thumbnail" + :file-if file-id + :revn revn + :message (ex-message cause)))))] + (partial rx/dispose! subscription)))) [:div {:class (stl/css :grid-item-th) :style {:background-color bg-color}