From 56556a3f3b52a5172b68045e10c322533090c96f Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Fri, 21 Jun 2024 09:27:11 +0200 Subject: [PATCH 1/3] :sparkles: Make the penpot_rpc_climit_timing metric as histogram --- backend/src/app/main.clj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/app/main.clj b/backend/src/app/main.clj index 7e963bb169..b0c6e0a4c7 100644 --- a/backend/src/app/main.clj +++ b/backend/src/app/main.clj @@ -126,7 +126,7 @@ {::mdef/name "penpot_rpc_climit_timing" ::mdef/help "Summary of the time between queuing and executing on the CLIMIT" ::mdef/labels ["name"] - ::mdef/type :summary} + ::mdef/type :histogram} :audit-http-handler-queue-size {::mdef/name "penpot_audit_http_handler_queue_size" From f249945dff6530f0667eb42034a6e36859331c70 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Fri, 21 Jun 2024 09:28:28 +0200 Subject: [PATCH 2/3] :sparkles: Include climit into the RPC handler metrics --- backend/src/app/rpc.clj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backend/src/app/rpc.clj b/backend/src/app/rpc.clj index b4acb2ea3c..c2a85413d9 100644 --- a/backend/src/app/rpc.clj +++ b/backend/src/app/rpc.clj @@ -192,10 +192,10 @@ (defn- wrap-all [cfg f mdata] (as-> f $ - (wrap-metrics cfg $ mdata) (cond/wrap cfg $ mdata) (retry/wrap-retry cfg $ mdata) (climit/wrap cfg $ mdata) + (wrap-metrics cfg $ mdata) (rlimit/wrap cfg $ mdata) (wrap-audit cfg $ mdata) (wrap-spec-conform cfg $ mdata) From 31818ec365b9c88efdf26b8266e22b67d499ec50 Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Fri, 21 Jun 2024 09:32:46 +0200 Subject: [PATCH 3/3] :sparkles: Replace other summary metrics with histogram --- backend/src/app/main.clj | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/backend/src/app/main.clj b/backend/src/app/main.clj index b0c6e0a4c7..5a959d39b7 100644 --- a/backend/src/app/main.clj +++ b/backend/src/app/main.clj @@ -102,13 +102,13 @@ {::mdef/name "penpot_tasks_timing" ::mdef/help "Background tasks timing (milliseconds)." ::mdef/labels ["name"] - ::mdef/type :summary} + ::mdef/type :histogram} :redis-eval-timing {::mdef/name "penpot_redis_eval_timing" ::mdef/help "Redis EVAL commands execution timings (ms)" ::mdef/labels ["name"] - ::mdef/type :summary} + ::mdef/type :histogram} :rpc-climit-queue {::mdef/name "penpot_rpc_climit_queue" @@ -144,7 +144,7 @@ {::mdef/name "penpot_audit_http_handler_timing" ::mdef/help "Summary of the time between queuing and executing on the audit log http handler" ::mdef/labels [] - ::mdef/type :summary} + ::mdef/type :histogram} :executors-active-threads {::mdef/name "penpot_executors_active_threads"