From 09259623da4f5243a6668d130553d2d6c5c0528c Mon Sep 17 00:00:00 2001 From: Andrey Antukh Date: Wed, 18 Nov 2026 08:28:51 +0000 Subject: [PATCH] :fire: Remove the unused Signed-off-by validator check_signed_off_by was never registered in the validator list, so it never ran, and no test exercised it. The DCO sign-off applies to external contributors through CONTRIBUTING.md, not to every commit, so the local checker has nothing to enforce there. Drop the function and the DCO mention in the script docstring. AI-assisted-by: deepseek-v4.1-flash Signed-off-by: Andrey Antukh --- scripts/check-commit | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/scripts/check-commit b/scripts/check-commit index 852bab8240..44ed1e47fd 100755 --- a/scripts/check-commit +++ b/scripts/check-commit @@ -4,7 +4,7 @@ Check commit messages against Penpot's commit guidelines. Validates commit messages using the rules defined in: - .github/workflows/commit-checker.yml (regex pattern) - - CONTRIBUTING.md (formatting rules, subject length, DCO) + - CONTRIBUTING.md (formatting rules, subject length) - .serena/memories/workflow/creating-commits.md (body wrapped at 80 chars) By default, checks HEAD. Use --commit to specify a different commit. @@ -222,17 +222,6 @@ def check_body_line_length(message): ) -def check_signed_off_by(message): - """Check for the DCO Signed-off-by line (required for code changes).""" - if "Signed-off-by:" not in message: - return False, ( - "Missing 'Signed-off-by:' line in the commit footer.\n" - " Add it with 'git commit -s' or append it manually:\n" - " Signed-off-by: Your Real Name " - ) - return True, None - - def check_co_authored_by(message): """Co-authored-by is allowed for humans, not for AI providers or bots.""" offenders = [