github/lowcode-engine
1
0
Fork 0
mirror of https://github.com/alibaba/lowcode-engine.git synced 2026-03-17 19:23:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(perf): 节点属性 settingEntry 按需构造

Browse Source
This commit is contained in:
力皓 2021-06-22 10:58:09 +08:00
parent 3c07142f71
commit f8100851c3
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/designer/src/document/node/node.ts
View File

@ -156,8 +156,6 @@ export class Node<Schema extends NodeSchema = NodeSchema> {
return this.componentMeta.icon; return this.componentMeta.icon;
} }
readonly settingEntry: SettingTopEntry;
private isInited = false; private isInited = false;
constructor(readonly document: DocumentModel, nodeSchema: Schema, options: any = {}) { constructor(readonly document: DocumentModel, nodeSchema: Schema, options: any = {}) {
@ -168,13 +166,11 @@ export class Node<Schema extends NodeSchema = NodeSchema> {
this.props = new Props(this, { this.props = new Props(this, {
children: isDOMText(children) || isJSExpression(children) ? children : '', children: isDOMText(children) || isJSExpression(children) ? children : '',
}); });
this.settingEntry = this.document.designer.createSettingEntry([this]);
} else { } else {
// 这里 props 被初始化两次，一次 new，一次 import，new 的实例需要给 propsReducer 的钩子去使用， // 这里 props 被初始化两次，一次 new，一次 import，new 的实例需要给 propsReducer 的钩子去使用，
// import 是为了使用钩子返回的值，并非完全幂等的操作，部分行为执行两次会有 bug， // import 是为了使用钩子返回的值，并非完全幂等的操作，部分行为执行两次会有 bug，
// 所以在 props 里会对 new / import 做一些区别化的解析 // 所以在 props 里会对 new / import 做一些区别化的解析
this.props = new Props(this, props, extras); this.props = new Props(this, props, extras);
this.settingEntry = this.document.designer.createSettingEntry([this]);
this._children = new NodeChildren(this as ParentalNode, this.initialChildren(children)); this._children = new NodeChildren(this as ParentalNode, this.initialChildren(children));
this._children.internalInitParent(); this._children.internalInitParent();
this.props.import( this.props.import(
@ -188,6 +184,14 @@ export class Node<Schema extends NodeSchema = NodeSchema> {
this.emitter = new EventEmitter(); this.emitter = new EventEmitter();
} }
_settingEntry: SettingTopEntry;
get settingEntry(): SettingTopEntry {
if (this._settingEntry) return this._settingEntry;
this._settingEntry = this.document.designer.createSettingEntry([this]);
return this._settingEntry;
}
private initProps(props: any): any { private initProps(props: any): any {
return this.document.designer.transformProps(props, this, TransformStage.Init); return this.document.designer.transformProps(props, this, TransformStage.Init);
} }