github/lowcode-engine
1
0
Fork 0
mirror of https://github.com/alibaba/lowcode-engine.git synced 2025-12-18 07:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add warning message when adding duplicate skeleton

Browse Source
This commit is contained in:
liujuping 2022-12-30 17:35:12 +08:00 committed by 林熠
parent bc5ec03884
commit e415ff6782
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/editor-skeleton/src/area.ts
View File

@ -1,9 +1,12 @@
/* eslint-disable max-len */ /* eslint-disable max-len */
import { obx, computed, makeObservable } from '@alilc/lowcode-editor-core'; import { obx, computed, makeObservable } from '@alilc/lowcode-editor-core';
import { Logger } from '@alilc/lowcode-utils';
import { IPublicTypeWidgetBaseConfig, IArea } from '@alilc/lowcode-types';
import { WidgetContainer } from './widget/widget-container'; import { WidgetContainer } from './widget/widget-container';
import { Skeleton } from './skeleton'; import { Skeleton } from './skeleton';
import { IWidget } from './widget/widget'; import { IWidget } from './widget/widget';
import { IPublicTypeWidgetBaseConfig, IArea } from '@alilc/lowcode-types';
const logger = new Logger({ level: 'warn', bizName: 'skeleton:area' });
export class Area<C extends IPublicTypeWidgetBaseConfig = any, T extends IWidget = IWidget> implements IArea<C, T> { export class Area<C extends IPublicTypeWidgetBaseConfig = any, T extends IWidget = IWidget> implements IArea<C, T> {
@obx private _visible = true; @obx private _visible = true;
@ -36,6 +39,7 @@ export class Area<C extends IPublicTypeWidgetBaseConfig = any, T extends IWidget
add(config: T | C): T { add(config: T | C): T {
const item = this.container.get(config.name); const item = this.container.get(config.name);
if (item) { if (item) {
logger.warn(`The ${config.name} has already been added to skeleton.`);
return item; return item;
} }
return this.container.add(config); return this.container.add(config);

2
packages/shell/src/api/skeleton.ts
View File

@ -11,7 +11,7 @@ export class Skeleton implements IPublicApiSkeleton {
private readonly [innerSkeletonSymbol]: InnerSkeleton; private readonly [innerSkeletonSymbol]: InnerSkeleton;
private readonly pluginName: string; private readonly pluginName: string;
get [skeletonSymbol]() { get [skeletonSymbol](): InnerSkeleton {
if (this.workspaceMode) { if (this.workspaceMode) {
return this[innerSkeletonSymbol]; return this[innerSkeletonSymbol];
} }