fix(shell/model): fix lint issues in shell/model

This commit is contained in:
JackLian 2023-01-13 09:33:21 +08:00 committed by 刘菊萍(絮黎)
parent 0d388a3076
commit 4fd3af10c5
14 changed files with 56 additions and 44 deletions

View File

@ -17,7 +17,7 @@ sidebar_position: 13
拖拽放置位置目标 拖拽放置位置目标
`@type {IPublicModelNode}` `@type {IPublicModelNode | null}`
相关类型:[IPublicModelNode](https://github.com/alibaba/lowcode-engine/blob/main/packages/types/src/shell/model/node.ts) 相关类型:[IPublicModelNode](https://github.com/alibaba/lowcode-engine/blob/main/packages/types/src/shell/model/node.ts)

View File

@ -6,16 +6,22 @@ import {
} from '@alilc/lowcode-types'; } from '@alilc/lowcode-types';
import { isNode } from '@alilc/lowcode-utils'; import { isNode } from '@alilc/lowcode-utils';
export interface IActiveTracker extends Omit< IPublicModelActiveTracker, 'track' > { export interface IActiveTracker extends Omit< IPublicModelActiveTracker, 'track' | 'onChange' > {
track(originalTarget: IPublicTypeActiveTarget | INode): void; track(originalTarget: ActiveTarget | INode): void;
onChange(fn: (target: ActiveTarget) => void): () => void;
}
export interface ActiveTarget extends Omit< IPublicTypeActiveTarget, 'node' > {
node: INode;
} }
export class ActiveTracker implements IActiveTracker { export class ActiveTracker implements IActiveTracker {
private emitter: IEventBus = createModuleEventBus('ActiveTracker'); private emitter: IEventBus = createModuleEventBus('ActiveTracker');
@obx.ref private _target?: IPublicTypeActiveTarget | INode; @obx.ref private _target?: ActiveTarget | INode;
track(originalTarget: IPublicTypeActiveTarget | INode) { track(originalTarget: ActiveTarget | INode) {
let target = originalTarget; let target = originalTarget;
if (isNode(originalTarget)) { if (isNode(originalTarget)) {
target = { node: originalTarget as INode }; target = { node: originalTarget as INode };
@ -25,11 +31,11 @@ export class ActiveTracker implements IActiveTracker {
} }
get currentNode() { get currentNode() {
return (this._target as IPublicTypeActiveTarget)?.node; return (this._target as ActiveTarget)?.node;
} }
get detail() { get detail() {
return (this._target as IPublicTypeActiveTarget)?.detail; return (this._target as ActiveTarget)?.detail;
} }
/** /**
@ -41,10 +47,10 @@ export class ActiveTracker implements IActiveTracker {
} }
get instance() { get instance() {
return (this._target as IPublicTypeActiveTarget)?.instance; return (this._target as ActiveTarget)?.instance;
} }
onChange(fn: (target: IPublicTypeActiveTarget) => void): () => void { onChange(fn: (target: ActiveTarget) => void): () => void {
this.emitter.addListener('change', fn); this.emitter.addListener('change', fn);
return () => { return () => {
this.emitter.removeListener('change', fn); this.emitter.removeListener('change', fn);

View File

@ -7,9 +7,9 @@ import {
IPublicTypeRect, IPublicTypeRect,
IPublicTypeLocationDetail, IPublicTypeLocationDetail,
IPublicTypeLocationData, IPublicTypeLocationData,
IPublicModelLocateEvent,
} from '@alilc/lowcode-types'; } from '@alilc/lowcode-types';
export interface Point { export interface Point {
clientX: number; clientX: number;
clientY: number; clientY: number;
@ -99,11 +99,15 @@ function isDocument(elem: any): elem is Document {
export function getWindow(elem: Element | Document): Window { export function getWindow(elem: Element | Document): Window {
return (isDocument(elem) ? elem : elem.ownerDocument!).defaultView!; return (isDocument(elem) ? elem : elem.ownerDocument!).defaultView!;
} }
export interface IDropLocation extends IPublicModelDropLocation { export interface IDropLocation extends Omit< IPublicModelDropLocation, 'target' | 'clone' > {
readonly source: string; readonly source: string;
get target(): INode;
get document(): IPublicModelDocumentModel; get document(): IPublicModelDocumentModel;
clone(event: IPublicModelLocateEvent): IDropLocation;
} }
export class DropLocation implements IDropLocation { export class DropLocation implements IDropLocation {
@ -126,7 +130,7 @@ export class DropLocation implements IDropLocation {
this.event = event; this.event = event;
} }
clone(event: ILocateEvent): DropLocation { clone(event: ILocateEvent): IDropLocation {
return new DropLocation({ return new DropLocation({
target: this.target, target: this.target,
detail: this.detail, detail: this.detail,

View File

@ -1,11 +1,11 @@
import { IPublicModelSettingTarget } from '@alilc/lowcode-types'; import { IPublicModelSettingTarget } from '@alilc/lowcode-types';
import { ComponentMeta } from '../../component-meta'; import { IComponentMeta } from '../../component-meta';
import { Designer } from '../designer'; import { Designer } from '../designer';
import { Node } from '../../document'; import { INode } from '../../document';
export interface SettingEntry extends IPublicModelSettingTarget { export interface SettingEntry extends IPublicModelSettingTarget {
readonly nodes: Node[]; readonly nodes: INode[];
readonly componentMeta: ComponentMeta | null; readonly componentMeta: IComponentMeta | null;
readonly designer: Designer; readonly designer: Designer;
// 顶端 // 顶端

View File

@ -2,8 +2,8 @@ import { obx, computed, makeObservable, runInAction, IEventBus, createModuleEven
import { GlobalEvent, IPublicModelEditor, IPublicTypeSetValueOptions } from '@alilc/lowcode-types'; import { GlobalEvent, IPublicModelEditor, IPublicTypeSetValueOptions } from '@alilc/lowcode-types';
import { uniqueId, isJSExpression, isSettingField } from '@alilc/lowcode-utils'; import { uniqueId, isJSExpression, isSettingField } from '@alilc/lowcode-utils';
import { SettingEntry } from './setting-entry'; import { SettingEntry } from './setting-entry';
import { Node } from '../../document'; import { INode } from '../../document';
import { ComponentMeta } from '../../component-meta'; import { IComponentMeta } from '../../component-meta';
import { Designer } from '../designer'; import { Designer } from '../designer';
import { Setters } from '@alilc/lowcode-shell'; import { Setters } from '@alilc/lowcode-shell';
@ -19,9 +19,9 @@ export class SettingPropEntry implements SettingEntry {
readonly setters: Setters; readonly setters: Setters;
readonly nodes: Node[]; readonly nodes: INode[];
readonly componentMeta: ComponentMeta | null; readonly componentMeta: IComponentMeta | null;
readonly designer: Designer; readonly designer: Designer;

View File

@ -11,12 +11,14 @@ export const UNSET = Symbol.for('unset');
// eslint-disable-next-line no-redeclare // eslint-disable-next-line no-redeclare
export type UNSET = typeof UNSET; export type UNSET = typeof UNSET;
export interface IProp extends Omit<IPublicModelProp, 'exportSchema' | 'node'> { export interface IProp extends Omit<IPublicModelProp, 'exportSchema' | 'node' | 'slotNode' > {
readonly props: Props; readonly props: Props;
readonly owner: INode; readonly owner: INode;
get slotNode(): INode | null;
delete(prop: Prop): void; delete(prop: Prop): void;
export(stage: IPublicEnumTransformStage): IPublicTypeCompositeValue; export(stage: IPublicEnumTransformStage): IPublicTypeCompositeValue;
@ -113,8 +115,8 @@ export class Prop implements IProp, IPropParent {
private _slotNode?: INode; private _slotNode?: INode;
get slotNode(): INode | undefined | null { get slotNode(): INode | null {
return this._slotNode; return this._slotNode || null;
} }
@obx.shallow private _items: Prop[] | null = null; @obx.shallow private _items: Prop[] | null = null;

View File

@ -1,5 +1,5 @@
import { IPublicModelActiveTracker, IPublicModelNode, IPublicTypeActiveTarget } from '@alilc/lowcode-types'; import { IPublicModelActiveTracker, IPublicModelNode, IPublicTypeActiveTarget } from '@alilc/lowcode-types';
import { IActiveTracker as InnerActiveTracker, INode as InnerNode } from '@alilc/lowcode-designer'; import { IActiveTracker as InnerActiveTracker, ActiveTarget } from '@alilc/lowcode-designer';
import { Node as ShellNode } from './node'; import { Node as ShellNode } from './node';
import { nodeSymbol } from '../symbols'; import { nodeSymbol } from '../symbols';
@ -16,9 +16,9 @@ export class ActiveTracker implements IPublicModelActiveTracker {
if (!fn) { if (!fn) {
return () => {}; return () => {};
} }
return this[activeTrackerSymbol].onChange((t: IPublicTypeActiveTarget) => { return this[activeTrackerSymbol].onChange((t: ActiveTarget) => {
const { node: innerNode, detail, instance } = t; const { node: innerNode, detail, instance } = t;
const publicNode = ShellNode.create(innerNode as InnerNode); const publicNode = ShellNode.create(innerNode);
const publicActiveTarget = { const publicActiveTarget = {
node: publicNode!, node: publicNode!,
detail, detail,

View File

@ -2,7 +2,7 @@ import {
IDropLocation as InnerDropLocation, IDropLocation as InnerDropLocation,
} from '@alilc/lowcode-designer'; } from '@alilc/lowcode-designer';
import { dropLocationSymbol } from '../symbols'; import { dropLocationSymbol } from '../symbols';
import { Node } from './node'; import { Node as ShellNode } from './node';
import { IPublicModelDropLocation, IPublicTypeLocationDetail, IPublicModelLocateEvent } from '@alilc/lowcode-types'; import { IPublicModelDropLocation, IPublicTypeLocationDetail, IPublicModelLocateEvent } from '@alilc/lowcode-types';
export class DropLocation implements IPublicModelDropLocation { export class DropLocation implements IPublicModelDropLocation {
@ -20,7 +20,7 @@ export class DropLocation implements IPublicModelDropLocation {
} }
get target() { get target() {
return Node.create(this[dropLocationSymbol].target); return ShellNode.create(this[dropLocationSymbol].target);
} }
get detail(): IPublicTypeLocationDetail { get detail(): IPublicTypeLocationDetail {

View File

@ -335,6 +335,7 @@ export class Node implements IPublicModelNode {
} }
const shellNode = new Node(node); const shellNode = new Node(node);
// @ts-ignore 挂载 shell node 实例 // @ts-ignore 挂载 shell node 实例
// eslint-disable-next-line no-param-reassign
node[shellNodeSymbol] = shellNode; node[shellNodeSymbol] = shellNode;
return shellNode; return shellNode;
} }

View File

@ -1,7 +1,6 @@
import { IPublicModelResource } from '@alilc/lowcode-types'; import { IPublicModelResource } from '@alilc/lowcode-types';
import { Resource as InnerResource } from '@alilc/lowcode-workspace'; import { Resource as InnerResource } from '@alilc/lowcode-workspace';
import { resourceSymbol } from '../symbols'; import { resourceSymbol } from '../symbols';
import { ResourceType } from './resource-type';
export class Resource implements IPublicModelResource { export class Resource implements IPublicModelResource {
readonly [resourceSymbol]: InnerResource; readonly [resourceSymbol]: InnerResource;

View File

@ -12,9 +12,9 @@ import {
IPublicTypeSetValueOptions, IPublicTypeSetValueOptions,
} from '@alilc/lowcode-types'; } from '@alilc/lowcode-types';
import { settingPropEntrySymbol } from '../symbols'; import { settingPropEntrySymbol } from '../symbols';
import { Node } from './node'; import { Node as ShellNode } from './node';
import { SettingTopEntry } from './setting-top-entry'; import { SettingTopEntry as ShellSettingTopEntry } from './setting-top-entry';
import { ComponentMeta } from './component-meta'; import { ComponentMeta as ShellComponentMeta } from './component-meta';
import { isCustomView } from '@alilc/lowcode-utils'; import { isCustomView } from '@alilc/lowcode-utils';
export class SettingPropEntry implements IPublicModelSettingPropEntry { export class SettingPropEntry implements IPublicModelSettingPropEntry {
@ -92,14 +92,14 @@ export class SettingPropEntry implements IPublicModelSettingPropEntry {
} }
get props(): IPublicModelSettingTopEntry { get props(): IPublicModelSettingTopEntry {
return SettingTopEntry.create(this[settingPropEntrySymbol].props); return ShellSettingTopEntry.create(this[settingPropEntrySymbol].props);
} }
/** /**
* *
*/ */
get node(): IPublicModelNode | null { get node(): IPublicModelNode | null {
return Node.create(this[settingPropEntrySymbol].getNode()); return ShellNode.create(this[settingPropEntrySymbol].getNode());
} }
/** /**
@ -113,7 +113,7 @@ export class SettingPropEntry implements IPublicModelSettingPropEntry {
* *
*/ */
get top(): IPublicModelSettingTopEntry { get top(): IPublicModelSettingTopEntry {
return SettingTopEntry.create(this[settingPropEntrySymbol].top); return ShellSettingTopEntry.create(this[settingPropEntrySymbol].top);
} }
/** /**
@ -127,7 +127,7 @@ export class SettingPropEntry implements IPublicModelSettingPropEntry {
* componentMeta * componentMeta
*/ */
get componentMeta(): IPublicModelComponentMeta | null { get componentMeta(): IPublicModelComponentMeta | null {
return ComponentMeta.create(this[settingPropEntrySymbol].componentMeta); return ShellComponentMeta.create(this[settingPropEntrySymbol].componentMeta);
} }
/** /**
@ -233,7 +233,7 @@ export class SettingPropEntry implements IPublicModelSettingPropEntry {
* @returns * @returns
*/ */
getProps(): IPublicModelSettingTopEntry { getProps(): IPublicModelSettingTopEntry {
return SettingTopEntry.create(this[settingPropEntrySymbol].getProps() as SettingEntry) as any; return ShellSettingTopEntry.create(this[settingPropEntrySymbol].getProps() as SettingEntry);
} }
/** /**

View File

@ -1,7 +1,7 @@
import { SettingEntry } from '@alilc/lowcode-designer'; import { SettingEntry } from '@alilc/lowcode-designer';
import { settingTopEntrySymbol } from '../symbols'; import { settingTopEntrySymbol } from '../symbols';
import { Node } from './node'; import { Node as ShellNode } from './node';
import { SettingPropEntry } from './setting-prop-entry'; import { SettingPropEntry as ShellSettingPropEntry } from './setting-prop-entry';
import { IPublicModelSettingTopEntry, IPublicModelNode, IPublicModelSettingPropEntry } from '@alilc/lowcode-types'; import { IPublicModelSettingTopEntry, IPublicModelNode, IPublicModelSettingPropEntry } from '@alilc/lowcode-types';
export class SettingTopEntry implements IPublicModelSettingTopEntry { export class SettingTopEntry implements IPublicModelSettingTopEntry {
@ -19,7 +19,7 @@ export class SettingTopEntry implements IPublicModelSettingTopEntry {
* *
*/ */
get node(): IPublicModelNode | null { get node(): IPublicModelNode | null {
return Node.create(this[settingTopEntrySymbol].getNode()); return ShellNode.create(this[settingTopEntrySymbol].getNode());
} }
/** /**
@ -28,7 +28,7 @@ export class SettingTopEntry implements IPublicModelSettingTopEntry {
* @returns * @returns
*/ */
get(propName: string | number): IPublicModelSettingPropEntry { get(propName: string | number): IPublicModelSettingPropEntry {
return SettingPropEntry.create(this[settingTopEntrySymbol].get(propName) as any); return ShellSettingPropEntry.create(this[settingTopEntrySymbol].get(propName) as any);
} }
/** /**

View File

@ -1,7 +1,7 @@
import { windowSymbol } from '../symbols'; import { windowSymbol } from '../symbols';
import { IPublicModelResource, IPublicModelWindow } from '@alilc/lowcode-types'; import { IPublicModelResource, IPublicModelWindow } from '@alilc/lowcode-types';
import { EditorWindow } from '@alilc/lowcode-workspace'; import { EditorWindow } from '@alilc/lowcode-workspace';
import { Resource } from './resource'; import { Resource as ShellResource } from './resource';
export class Window implements IPublicModelWindow { export class Window implements IPublicModelWindow {
private readonly [windowSymbol]: EditorWindow; private readonly [windowSymbol]: EditorWindow;
@ -19,7 +19,7 @@ export class Window implements IPublicModelWindow {
} }
get resource(): IPublicModelResource { get resource(): IPublicModelResource {
return new Resource(this[windowSymbol].resource); return new ShellResource(this[windowSymbol].resource);
} }
constructor(editorWindow: EditorWindow) { constructor(editorWindow: EditorWindow) {

View File

@ -7,7 +7,7 @@ export interface IPublicModelDropLocation {
* *
* get target of dropLocation * get target of dropLocation
*/ */
get target(): IPublicModelNode; get target(): IPublicModelNode | null;
/** /**
* *