mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-10 18:58:21 +00:00
c1b7f1d189
* feat(middleware): inject dynamic context via DynamicContextMiddleware
Move memory and current date out of the system prompt and into a
dedicated <system-reminder> HumanMessage injected once per session
(frozen-snapshot pattern) via a new DynamicContextMiddleware.
This keeps the system prompt byte-exact across all users and sessions,
enabling maximum Anthropic/Bedrock prefix-cache reuse.
Key design decisions:
- ID-swap technique: reminder takes the first HumanMessage's ID
(replacing it in-place via add_messages), original content gets a
derived `{id}__user` ID (appended after). Preserves correct ordering.
- hide_from_ui: True on reminder messages so frontend filters them out.
- Midnight crossing: date-update reminder injected before the current
turn's HumanMessage when the conversation spans midnight.
- INFO-level logging for production diagnostics.
Also adds prompt-caching breakpoint budget enforcement tests and
updates ClaudeChatModel docs to reference the new pattern.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat(token-usage): log input/output token detail breakdown in middleware
Extend the LLM token usage log line to include input_token_details and
output_token_details (cache_creation, cache_read, reasoning, audio, etc.)
when present. Adds tests covering Anthropic cache detail logging from
both usage_metadata and response_metadata.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: fix nginx
* fix(middleware): always inject date; gate memory on injection_enabled
Date injection is now unconditional — it is part of the static system
prompt replacement and should always be present. Memory injection
remains gated by `memory.injection_enabled` in the app config.
Previously the entire DynamicContextMiddleware was skipped when
injection_enabled was False, which also suppressed the date.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(lint): format files and correct test assertions for token usage middleware
- ruff format dynamic_context_middleware.py and test_claude_provider_prompt_caching.py
- Remove unused pytest import from test_dynamic_context_middleware.py
- Fix two tests that asserted response_metadata fallback logic that
doesn't exist: replace with tests that match actual middleware behavior
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(middleware): address Copilot review comments on DynamicContextMiddleware
- Use additional_kwargs flag for reminder detection instead of content
substring matching, so user messages containing '<system-reminder>'
are not mistakenly treated as injected reminders
- Generate stable UUID when original HumanMessage.id is None to prevent
ambiguous 'None__user' derived IDs and message collisions
- Downgrade per-turn no-op log to DEBUG; keep actual injection events at INFO
- Add two new tests: missing-id UUID fallback and user-text false-positive
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
236 lines
7.1 KiB
Python
236 lines
7.1 KiB
Python
"""Tests for CSRF middleware."""
|
|
|
|
from fastapi import FastAPI
|
|
from starlette.testclient import TestClient
|
|
|
|
from app.gateway.csrf_middleware import CSRFMiddleware
|
|
|
|
|
|
def _make_app() -> FastAPI:
|
|
app = FastAPI()
|
|
app.add_middleware(CSRFMiddleware)
|
|
|
|
@app.post("/api/v1/auth/login/local")
|
|
async def login_local():
|
|
return {"ok": True}
|
|
|
|
@app.post("/api/v1/auth/register")
|
|
async def register():
|
|
return {"ok": True}
|
|
|
|
@app.post("/api/threads/abc/runs/stream")
|
|
async def protected_mutation():
|
|
return {"ok": True}
|
|
|
|
return app
|
|
|
|
|
|
def test_auth_post_rejects_cross_origin_browser_request():
|
|
"""CSRF-exempt auth routes must not accept hostile browser origins.
|
|
|
|
Login/register endpoints intentionally skip the double-submit token because
|
|
first-time callers do not have a token yet. They still set an auth session,
|
|
so a hostile cross-site form POST must be rejected to avoid login CSRF /
|
|
session fixation.
|
|
"""
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://evil.example"},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "Cross-site auth request denied."
|
|
|
|
|
|
def test_auth_post_allows_same_origin_browser_request():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://deerflow.example"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_auth_post_rejects_malformed_origin_with_path():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://deerflow.example/path"},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "Cross-site auth request denied."
|
|
assert response.cookies.get("csrf_token") is None
|
|
|
|
|
|
def test_auth_post_rejects_malformed_origin_with_invalid_port():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://deerflow.example:bad"},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "Cross-site auth request denied."
|
|
assert response.cookies.get("csrf_token") is None
|
|
|
|
|
|
def test_auth_post_allows_same_origin_default_port_equivalence():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://deerflow.example:443"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_auth_post_allows_forwarded_same_origin():
|
|
client = TestClient(_make_app(), base_url="http://internal:8000")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={
|
|
"Origin": "https://deerflow.example",
|
|
"X-Forwarded-Proto": "https",
|
|
"X-Forwarded-Host": "deerflow.example, internal:8000",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_auth_post_allows_forwarded_same_origin_with_non_default_port():
|
|
client = TestClient(_make_app(), base_url="http://internal:8000")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={
|
|
"Origin": "http://localhost:2026",
|
|
"X-Forwarded-Proto": "http",
|
|
"X-Forwarded-Host": "localhost:2026",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_auth_post_allows_rfc_forwarded_same_origin():
|
|
client = TestClient(_make_app(), base_url="http://internal:8000")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={
|
|
"Origin": "https://deerflow.example",
|
|
"Forwarded": "proto=https;host=deerflow.example",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
assert "secure" in response.headers["set-cookie"].lower()
|
|
|
|
|
|
def test_auth_post_allows_explicit_configured_origin(monkeypatch):
|
|
monkeypatch.setenv("GATEWAY_CORS_ORIGINS", "https://app.example")
|
|
client = TestClient(_make_app(), base_url="https://api.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/register",
|
|
headers={"Origin": "https://app.example"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_auth_post_does_not_treat_wildcard_cors_as_allowed_origin(monkeypatch):
|
|
monkeypatch.setenv("GATEWAY_CORS_ORIGINS", "*")
|
|
client = TestClient(_make_app(), base_url="https://api.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://evil.example"},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "Cross-site auth request denied."
|
|
|
|
|
|
def test_auth_post_sets_strict_samesite_csrf_cookie():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/v1/auth/login/local",
|
|
headers={"Origin": "https://deerflow.example"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
set_cookie = response.headers["set-cookie"].lower()
|
|
assert "csrf_token=" in set_cookie
|
|
assert "samesite=strict" in set_cookie
|
|
assert "secure" in set_cookie
|
|
|
|
|
|
def test_auth_post_without_origin_still_allows_non_browser_clients():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post("/api/v1/auth/login/local")
|
|
|
|
assert response.status_code == 200
|
|
assert response.cookies.get("csrf_token")
|
|
|
|
|
|
def test_non_auth_mutation_still_requires_double_submit_token():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
|
|
response = client.post(
|
|
"/api/threads/abc/runs/stream",
|
|
headers={"Origin": "https://deerflow.example"},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "CSRF token missing. Include X-CSRF-Token header."
|
|
|
|
|
|
def test_non_auth_mutation_allows_valid_double_submit_token():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
client.cookies.set("csrf_token", "known-token")
|
|
|
|
response = client.post(
|
|
"/api/threads/abc/runs/stream",
|
|
headers={
|
|
"Origin": "https://deerflow.example",
|
|
"X-CSRF-Token": "known-token",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
|
|
|
|
def test_non_auth_mutation_rejects_mismatched_double_submit_token():
|
|
client = TestClient(_make_app(), base_url="https://deerflow.example")
|
|
client.cookies.set("csrf_token", "cookie-token")
|
|
|
|
response = client.post(
|
|
"/api/threads/abc/runs/stream",
|
|
headers={
|
|
"Origin": "https://deerflow.example",
|
|
"X-CSRF-Token": "header-token",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert response.json()["detail"] == "CSRF token mismatch."
|