Hyeonsang Cho 2814bd5d49

fix(models): stop reasoning_effort from reaching the constructor twice (#5403) ...

* fix(models): stop reasoning_effort from reaching the constructor twice

The regular lead-agent build forwards reasoning_effort to
create_chat_model even when neither the request nor the custom agent
chose one. The factory spread that kwarg next to the profile settings,
so any profile that also yielded reasoning_effort -- a top-level value,
when_thinking_enabled, when_thinking_disabled, or the minimal effort the
extra_body.thinking disable path injects -- made the constructor raise
"got multiple values for keyword argument 'reasoning_effort'", and the
lead agent could not be built for that model. #2017 moved the
factory-injected value out of kwargs but left the caller-supplied one.

The requested effort now leaves kwargs once and layers like
model_overrides: a non-None value replaces the profile value, None keeps
it, and the thinking transforms applied afterwards still decide the
final value. Codex keeps resolving the requested value itself, so a
level it does not accept and a profile without effort support still
fall back to medium.

* docs(changelog): reference #5403 in the reasoning_effort collision fix entry

2026-09-13 23:14:07 +08:00

..

extension-api

feat(extensions): let an out-of-tree extension observe what the agent did (#4863)

2026-08-23 09:57:12 +08:00

harness

fix(models): stop reasoning_effort from reaching the constructor twice (#5403)

2026-09-13 23:14:07 +08:00