Totoro 94e69d6ff7
feat(frontend): reference conversations from the composer (#5465)
* feat(frontend): reference conversations from the composer

Adds a "Reference a conversation" button next to the attachment button,
shown only while GET /api/features reports read_conversation enabled. It
opens a picker over the recent-conversation list (current thread excluded,
capped at max_references) and shows removable chips in the composer.

On send the thread IDs ride SendMessageOptions.conversationReferences into
run context.conversation_references, which the Gateway consumes at
admission; the LangGraph SDK drops unknown top-level body fields. A
display-only copy ({thread_id, title}) on the visible human message lets
the transcript render read-only chips linking to the source.

References are per message: not persisted with the draft and cleared on
send or thread switch; regenerating or editing a turn runs without them
unless they are attached again.

Related to #5398. Depends on #5463.

* fix(frontend): pin the run-context contract and finish the picker states

Both thread.submit paths now build their run context through one exported
buildRunContext helper, tested directly: attached references travel as a
plain string[] under context.conversation_references only when the caller
passed them, a stray key in local settings is dropped instead of forwarded,
and the regenerate/edit replay path never carries references.

The picker shows a loading row while the conversation list is still in
flight instead of claiming there are no conversations, and the transcript
chip group is labelled with the previously unused referencedConversations
translation.

* fix(frontend): route conversation-reference chips to custom-agent sources

The picker offered custom-agent conversations but kept only the thread ID
and title, so transcript chips always linked to /workspace/chats/{id} and
dropped the source's custom-agent context on navigation.

Preserve the agent identity end to end: the picker now attaches
agentNameOfThread() (context first, then metadata.agent_name, mirroring
pathOfThread) to the selection, the display-only additional_kwargs metadata
round-trips it as agent_name, and the transcript chip passes it to
pathOfThread so custom-agent sources resolve to
/workspace/agents/{agent}/chats/{id}.

Tests: agent_name metadata round-trip and malformed-entry tolerance, picker
toggle carrying the metadata agent with run context winning, and a
picker-to-transcript regression pinning the /workspace/agents/writer/chats/
source-1 href.

---------

Co-authored-by: Totoro-qaq <279883115+Totoro-qaq@users.noreply.github.com>
2026-09-16 21:19:52 +08:00

73 lines
2.4 KiB
TypeScript

import { expect, test } from "@rstest/core";
import {
CONVERSATION_REFERENCES_KWARG,
buildConversationReferenceMetadata,
readConversationReferences,
type ConversationReference,
} from "@/core/conversation-references";
const references: ConversationReference[] = [
{ threadId: "thread-a", title: "Requirements review" },
{ threadId: "thread-b", title: "Design notes" },
];
test("metadata carries thread id and title only, under one display-only key", () => {
expect(buildConversationReferenceMetadata(references)).toEqual({
[CONVERSATION_REFERENCES_KWARG]: [
{ thread_id: "thread-a", title: "Requirements review" },
{ thread_id: "thread-b", title: "Design notes" },
],
});
});
test("reading round-trips what build wrote", () => {
expect(
readConversationReferences(buildConversationReferenceMetadata(references)),
).toEqual(references);
});
test("metadata round-trips the source's custom agent when present", () => {
const withAgent: ConversationReference[] = [
{ threadId: "thread-w", title: "Writer notes", agentName: "writer" },
];
expect(buildConversationReferenceMetadata(withAgent)).toEqual({
[CONVERSATION_REFERENCES_KWARG]: [
{ thread_id: "thread-w", title: "Writer notes", agent_name: "writer" },
],
});
expect(
readConversationReferences(buildConversationReferenceMetadata(withAgent)),
).toEqual(withAgent);
});
test("reading tolerates missing, malformed and duplicate entries", () => {
expect(readConversationReferences(undefined)).toEqual([]);
expect(readConversationReferences({})).toEqual([]);
expect(readConversationReferences({ conversation_references: "x" })).toEqual(
[],
);
expect(
readConversationReferences({
conversation_references: [
{ thread_id: "thread-a", title: "Kept" },
{ thread_id: "thread-a", title: "Duplicate of the first" },
{ thread_id: 7, title: "Bad id" },
{ thread_id: "", title: "Empty id" },
{ thread_id: "thread-c" },
{ thread_id: "thread-d", title: "" },
{ thread_id: "thread-f", agent_name: 42 },
{ thread_id: "thread-g", agent_name: "" },
null,
"thread-e",
],
}),
).toEqual([
{ threadId: "thread-a", title: "Kept" },
{ threadId: "thread-c", title: "" },
{ threadId: "thread-d", title: "" },
{ threadId: "thread-f", title: "" },
{ threadId: "thread-g", title: "" },
]);
});