mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-04-25 11:18:22 +00:00
92c7a20cb7
* fix(security): disable host bash by default in local sandbox * fix(security): address review feedback for local bash hardening * fix(ci): sort live test imports for lint * style: apply backend formatter --------- Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
82 lines
3.0 KiB
Python
82 lines
3.0 KiB
Python
from types import SimpleNamespace
|
|
|
|
from deerflow.tools.tools import get_available_tools
|
|
|
|
|
|
def _make_config(*, allow_host_bash: bool, sandbox_use: str = "deerflow.sandbox.local:LocalSandboxProvider", extra_tools: list[SimpleNamespace] | None = None):
|
|
return SimpleNamespace(
|
|
tools=[
|
|
SimpleNamespace(name="bash", group="bash", use="deerflow.sandbox.tools:bash_tool"),
|
|
SimpleNamespace(name="ls", group="file:read", use="tests:ls_tool"),
|
|
*(extra_tools or []),
|
|
],
|
|
models=[],
|
|
sandbox=SimpleNamespace(
|
|
use=sandbox_use,
|
|
allow_host_bash=allow_host_bash,
|
|
),
|
|
tool_search=SimpleNamespace(enabled=False),
|
|
get_model_config=lambda name: None,
|
|
)
|
|
|
|
|
|
def test_get_available_tools_hides_bash_for_default_local_sandbox(monkeypatch):
|
|
monkeypatch.setattr("deerflow.tools.tools.get_app_config", lambda: _make_config(allow_host_bash=False))
|
|
monkeypatch.setattr(
|
|
"deerflow.tools.tools.resolve_variable",
|
|
lambda use, _: SimpleNamespace(name="bash" if "bash" in use else "ls"),
|
|
)
|
|
|
|
names = [tool.name for tool in get_available_tools(include_mcp=False, subagent_enabled=False)]
|
|
|
|
assert "bash" not in names
|
|
assert "ls" in names
|
|
|
|
|
|
def test_get_available_tools_keeps_bash_when_explicitly_enabled(monkeypatch):
|
|
monkeypatch.setattr("deerflow.tools.tools.get_app_config", lambda: _make_config(allow_host_bash=True))
|
|
monkeypatch.setattr(
|
|
"deerflow.tools.tools.resolve_variable",
|
|
lambda use, _: SimpleNamespace(name="bash" if "bash" in use else "ls"),
|
|
)
|
|
|
|
names = [tool.name for tool in get_available_tools(include_mcp=False, subagent_enabled=False)]
|
|
|
|
assert "bash" in names
|
|
assert "ls" in names
|
|
|
|
|
|
def test_get_available_tools_hides_renamed_host_bash_alias(monkeypatch):
|
|
config = _make_config(
|
|
allow_host_bash=False,
|
|
extra_tools=[SimpleNamespace(name="shell", group="bash", use="deerflow.sandbox.tools:bash_tool")],
|
|
)
|
|
monkeypatch.setattr("deerflow.tools.tools.get_app_config", lambda: config)
|
|
monkeypatch.setattr(
|
|
"deerflow.tools.tools.resolve_variable",
|
|
lambda use, _: SimpleNamespace(name="bash" if "bash_tool" in use else "ls"),
|
|
)
|
|
|
|
names = [tool.name for tool in get_available_tools(include_mcp=False, subagent_enabled=False)]
|
|
|
|
assert "bash" not in names
|
|
assert "shell" not in names
|
|
assert "ls" in names
|
|
|
|
|
|
def test_get_available_tools_keeps_bash_for_aio_sandbox(monkeypatch):
|
|
config = _make_config(
|
|
allow_host_bash=False,
|
|
sandbox_use="deerflow.community.aio_sandbox:AioSandboxProvider",
|
|
)
|
|
monkeypatch.setattr("deerflow.tools.tools.get_app_config", lambda: config)
|
|
monkeypatch.setattr(
|
|
"deerflow.tools.tools.resolve_variable",
|
|
lambda use, _: SimpleNamespace(name="bash" if "bash_tool" in use else "ls"),
|
|
)
|
|
|
|
names = [tool.name for tool in get_available_tools(include_mcp=False, subagent_enabled=False)]
|
|
|
|
assert "bash" in names
|
|
assert "ls" in names
|