mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-04-25 11:18:22 +00:00
c2f7be37b3
view_image_tool.py had a top-level import of deerflow.sandbox.tools, which
created a circular dependency chain:
sandbox.tools
-> deerflow.agents.thread_state (triggers agents/__init__.py)
-> agents/factory.py
-> tools/builtins/__init__.py
-> view_image_tool.py
-> deerflow.sandbox.tools <-- circular!
This caused ImportError when any test directly imported sandbox.tools,
making test_sandbox_tools_security.py fail to collect since #1522.
Fix: move the sandbox.tools import inside the view_image_tool function body.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
96 lines
3.5 KiB
Python
96 lines
3.5 KiB
Python
import base64
|
|
import mimetypes
|
|
from pathlib import Path
|
|
from typing import Annotated
|
|
|
|
from langchain.tools import InjectedToolCallId, ToolRuntime, tool
|
|
from langchain_core.messages import ToolMessage
|
|
from langgraph.types import Command
|
|
from langgraph.typing import ContextT
|
|
|
|
from deerflow.agents.thread_state import ThreadState
|
|
|
|
|
|
@tool("view_image", parse_docstring=True)
|
|
def view_image_tool(
|
|
runtime: ToolRuntime[ContextT, ThreadState],
|
|
image_path: str,
|
|
tool_call_id: Annotated[str, InjectedToolCallId],
|
|
) -> Command:
|
|
"""Read an image file.
|
|
|
|
Use this tool to read an image file and make it available for display.
|
|
|
|
When to use the view_image tool:
|
|
- When you need to view an image file.
|
|
|
|
When NOT to use the view_image tool:
|
|
- For non-image files (use present_files instead)
|
|
- For multiple files at once (use present_files instead)
|
|
|
|
Args:
|
|
image_path: Absolute path to the image file. Common formats supported: jpg, jpeg, png, webp.
|
|
"""
|
|
from deerflow.sandbox.tools import get_thread_data, replace_virtual_path
|
|
|
|
# Replace virtual path with actual path
|
|
# /mnt/user-data/* paths are mapped to thread-specific directories
|
|
thread_data = get_thread_data(runtime)
|
|
actual_path = replace_virtual_path(image_path, thread_data)
|
|
|
|
# Validate that the path is absolute
|
|
path = Path(actual_path)
|
|
if not path.is_absolute():
|
|
return Command(
|
|
update={"messages": [ToolMessage(f"Error: Path must be absolute, got: {image_path}", tool_call_id=tool_call_id)]},
|
|
)
|
|
|
|
# Validate that the file exists
|
|
if not path.exists():
|
|
return Command(
|
|
update={"messages": [ToolMessage(f"Error: Image file not found: {image_path}", tool_call_id=tool_call_id)]},
|
|
)
|
|
|
|
# Validate that it's a file (not a directory)
|
|
if not path.is_file():
|
|
return Command(
|
|
update={"messages": [ToolMessage(f"Error: Path is not a file: {image_path}", tool_call_id=tool_call_id)]},
|
|
)
|
|
|
|
# Validate image extension
|
|
valid_extensions = {".jpg", ".jpeg", ".png", ".webp"}
|
|
if path.suffix.lower() not in valid_extensions:
|
|
return Command(
|
|
update={"messages": [ToolMessage(f"Error: Unsupported image format: {path.suffix}. Supported formats: {', '.join(valid_extensions)}", tool_call_id=tool_call_id)]},
|
|
)
|
|
|
|
# Detect MIME type from file extension
|
|
mime_type, _ = mimetypes.guess_type(actual_path)
|
|
if mime_type is None:
|
|
# Fallback to default MIME types for common image formats
|
|
extension_to_mime = {
|
|
".jpg": "image/jpeg",
|
|
".jpeg": "image/jpeg",
|
|
".png": "image/png",
|
|
".webp": "image/webp",
|
|
}
|
|
mime_type = extension_to_mime.get(path.suffix.lower(), "application/octet-stream")
|
|
|
|
# Read image file and convert to base64
|
|
try:
|
|
with open(actual_path, "rb") as f:
|
|
image_data = f.read()
|
|
image_base64 = base64.b64encode(image_data).decode("utf-8")
|
|
except Exception as e:
|
|
return Command(
|
|
update={"messages": [ToolMessage(f"Error reading image file: {str(e)}", tool_call_id=tool_call_id)]},
|
|
)
|
|
|
|
# Update viewed_images in state
|
|
# The merge_viewed_images reducer will handle merging with existing images
|
|
new_viewed_images = {image_path: {"base64": image_base64, "mime_type": mime_type}}
|
|
|
|
return Command(
|
|
update={"viewed_images": new_viewed_images, "messages": [ToolMessage("Successfully read image", tool_call_id=tool_call_id)]},
|
|
)
|