mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-08-18 02:38:54 +00:00
* feat(checkpoint): dual-mode checkpoint storage with LangGraph DeltaChannel
Add a restart-required database.checkpoint_channel_mode ("full" default,
"delta") that stores the messages channel via LangGraph 1.2 DeltaChannel,
cutting checkpoint storage from O(n^2) to O(n) for append-only history.
Existing full checkpoints seed delta state transparently; no data migration.
- config: mode schema + freeze-on-first-use with
CheckpointModeReconfigurationError; mode marker persisted in checkpoint
metadata; unsafe delta->full downgrade rejected fail-closed with
CheckpointModeMismatchError (run-level error, failed state read)
- state: delta message state schema; CheckpointStateAccessor centralizes
materialized reads for all consumers (threads API, branches,
regeneration, compaction, state updates, memory, goal workers)
- runtime: raw writers (run durations, interrupted title, thread goal)
parent their checkpoints to the checkpoint they derive from, preserving
delta ancestry; rollback forks the pre-run lineage through a state
mutation graph with Overwrite restores; InMemorySaver delta-history
override delegates to the base walk (fixes dropped first write after
migration, also present upstream)
- tests: conformance suite over {memory, sqlite, postgres} covering
migration replay, stable message IDs, storage shape and writer
preservation; conftest fixture isolates the frozen mode between tests;
stale config fakes refreshed
- ci: backend unit tests gain a postgres service
* fix(checkpoint): close materialization gaps in goal flow, guard public factory
- Route goal-continuation message reads through CheckpointStateAccessor:
raw channel_values reads see the delta sentinel in delta mode, which
disabled goal continuation (stand_down=no_durable_end_of_turn) after
durable assistant turns. Raw tuples remain for tuple-only metadata
(checkpoint id, pending_writes).
- Reject checkpoint_channel_mode='delta' + checkpointer in
create_deerflow_agent at construction: factory-built persisted graphs
bypass mode-marker injection and the fail-closed gate, reproducing
silent mixed-mode state loss. Delta without persistence stays allowed.
- Import the postgres saver lazily (pytest.importorskip in the fixture)
so the documented default install collects the suite; add a CI job
running pytest --collect-only on uv sync --group dev without extras.
- Fix test_checkpointer fallback test to patch get_app_config at its
use site (provider module), making it deterministic when a local
config.yaml selects a persistent backend.
* fix(gateway): preserve extension-owned channels in state mutations, bump config version
- build_state_mutation_graph / build_checkpoint_state_mutation_accessor
accept an explicit state_schema; branch and POST /state now compile the
mutation graph from the thread's effective schema
(graph_state_schema on the assistant graph). The base-ThreadState
fallback silently discarded channels contributed by custom
AgentMiddleware.state_schema on branch (data loss) and returned a
false-success 200 on POST /state.
- POST /state validates values keys against the mutation graph's
channels and rejects unknown fields with 422 instead of ignoring
them; reducer detection covers extension channels
(BinaryOperatorAggregate or DeltaChannel) so Overwrite replace
semantics work for middleware reducers in both modes.
- Endpoint regression: custom AgentMiddleware.state_schema value
survives branch, updates through POST /state, and an unknown field
receives 422.
- config_version 26 -> 27 for the new database.checkpoint_channel_mode
(example, Helm chart values + README, support-bundle fixture), so
existing installs get the outdated-config warning and
make config-upgrade merges the field; covered by a test driving the
real example file and the real config-upgrade script.
* fix(gateway): resolve assistant schema via one boundary, copy branch reducer values with Overwrite
GET /threads/{id}/state now resolves the thread's assistant_id through a
single reusable boundary (thread metadata -> assistant_id -> effective
graph), so channels contributed by a custom AgentMiddleware.state_schema
are materialized instead of dropped by the default lead schema. POST
/state uses the same boundary instead of resolving the schema ad hoc.
Branch writes wrap every copied reducer channel in Overwrite (derived
from the effective mutation graph: BinaryOperatorAggregate + DeltaChannel),
not just messages, so already-aggregated values are never re-merged.
Regression tests use a real AgentMiddleware.state_schema with a
non-identity reducer in both full and delta modes: GET /state returns the
extension value, POST /state replaces it, branch preserves it
byte-for-byte; the unknown-field 422 is a separate assertion.
* refactor(checkpoint): collapse read-path round-trips and ship dual-mode parity tests
Address review round 4 on PR #4292:
- Push ahistory/history limit through Pregel into checkpointer.alist
(SQL LIMIT) instead of materializing all rows and breaking in Python
- Fold the read-side mode-compat gate onto the returned snapshot's
metadata; only writes keep the pre-write tuple fetch (fail-closed)
- Cache factory-built accessor graphs per (assistant_id, mode) with
factory-identity revalidation; state reads no longer build a lead
agent per request
- get_thread: one snapshot fetch + one raw pending_writes fetch on the
resolved checkpoint (post-checkpoint __error__ writes never surface
in snapshot.tasks; verified empirically)
- DeerFlowClient.get_thread: single checkpointer.list walk collects
pending_writes per checkpoint instead of N get_tuple calls
- InMemorySaver delta-history patch: stand-down when the upstream
override disappears, try/except guard, validated-version warning,
guard tests
- make_lead_agent mode precedence: first freeze is owned by app_config
(client-supplied configurable key ignored); once frozen, injected
key/app_config must match or fail closed
- Rollback: lock in non-message channel restoration via fork
inheritance with a dedicated reducer-channel test
- Add tests/test_threads_checkpoint_mode.py and
tests/test_gateway_checkpoint_mode.py referenced by AGENTS.md and
the PR validation section: lifecycle parity (memory + sqlite),
per-step blob-count storage guard, gateway endpoint parity
Counted-saver tests pin checkpoint round-trips for aget/ahistory so
these regressions cannot silently return.
* fix(checkpoint): precise mode-mismatch HTTP mapping, gate E2E, and accessor resilience
- threads router: map CheckpointModeMismatchError to 409 (with cause and
thread id) and CheckpointModeReconfigurationError to 503 across all state
endpoints instead of swallowing both into a generic 500
- gate coverage: seed a real delta checkpoint into AsyncSqliteSaver and
assert aget/aupdate/ahistory fail closed; assert 409 at the HTTP boundary
through the real route stack
- rollback: compile the restore mutation graph with the thread's effective
state schema per the build_state_mutation_graph contract
- inheritance contract locks: rollback and manual compaction preserve
middleware-contributed channels via checkpoint fork cloning
- services: revalidate the accessor-graph cache against app_config identity
so config.yaml hot-reloads never serve a stale compiled graph
- services: degrade full-mode state reads to raw checkpointer reads when the
agent factory is unavailable (delta gate still applies; delta mode has no
fallback)
- deps: override websockets==16.0 (langgraph-sdk 0.4.2's <16 pin silently
downgraded 16.0 -> 15.0.1; pin is not grounded in any API incompatibility)
and bump the langchain lower bound to what the lockfile actually resolves
* fix(checkpoint): include anchor checkpoint in degraded history walk + cover get_thread
- _RawCheckpointReadAccessor.ahistory: alist(before=...) is exclusive while
pregel's get_state_history treats config.checkpoint_id as the inclusive
start; fetch the anchor explicitly so both read paths paginate identically
- extend the degraded-path gateway test: GET /thread returns raw values, and
POST /history with before starts at the anchor checkpoint
* fix(gateway): preserve degraded checkpoint timestamps
* fix(gateway): harden degraded checkpoint access
* fix(gateway): resolve assistants for checkpoint reads
---------
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
100 lines
4.9 KiB
Python
100 lines
4.9 KiB
Python
"""Compatibility patches for third-party checkpoint savers.
|
|
|
|
Lives at the top-level package (not ``deerflow.runtime``) so it can be
|
|
imported from ``deerflow.agents.thread_state`` without pulling in the heavy
|
|
``deerflow.runtime`` package __init__ (which eagerly imports the runs
|
|
machinery). Anchored from ``deerflow.agents.thread_state`` so every process
|
|
that builds a DeerFlow graph (gateway, workers, in-process LangGraph
|
|
runtime, tests) runs with the fixes in place.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.metadata
|
|
import logging
|
|
from typing import Any
|
|
|
|
from langgraph.checkpoint.base import BaseCheckpointSaver
|
|
from langgraph.checkpoint.memory import InMemorySaver
|
|
from packaging.version import Version
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_PATCH_FLAG = "_deerflow_delta_history_patched"
|
|
# The patch was authored and verified against langgraph 1.2.9
|
|
# (langgraph/checkpoint/memory/__init__.py::InMemorySaver.get_delta_channel_history).
|
|
# On any newer LangGraph the override must be re-inspected before keeping the
|
|
# patch: if upstream fixed or removed it, this module must stand down.
|
|
_PATCH_VALIDATED_LANGGRAPH_VERSION = Version("1.2.9")
|
|
|
|
|
|
def _get_delta_channel_history_via_base(self: Any, *, config: Any, channels: Any) -> Any:
|
|
return BaseCheckpointSaver.get_delta_channel_history(self, config=config, channels=channels)
|
|
|
|
|
|
async def _aget_delta_channel_history_via_base(self: Any, *, config: Any, channels: Any) -> Any:
|
|
return await BaseCheckpointSaver.aget_delta_channel_history(self, config=config, channels=channels)
|
|
|
|
|
|
def _upstream_override_present() -> bool:
|
|
"""True while InMemorySaver still ships its own (buggy) override."""
|
|
return (
|
|
getattr(InMemorySaver, "get_delta_channel_history", None) is not None
|
|
and InMemorySaver.get_delta_channel_history is not BaseCheckpointSaver.get_delta_channel_history
|
|
and InMemorySaver.aget_delta_channel_history is not BaseCheckpointSaver.aget_delta_channel_history
|
|
)
|
|
|
|
|
|
def ensure_inmemory_delta_history_patch() -> None:
|
|
"""Fix InMemorySaver dropping writes on full -> delta migrated threads.
|
|
|
|
``InMemorySaver.get_delta_channel_history`` overrides the base walk with a
|
|
single-pass version that, upon reaching the first checkpoint carrying a
|
|
non-empty plain-value blob for a channel, skips that checkpoint's *own*
|
|
pending writes as "subsumed" by the blob. That is only true when the blob
|
|
was written by that same checkpoint. When the version was carried forward
|
|
from an older ancestor - exactly the first superstep after a full -> delta
|
|
migration, where the input write lands on a checkpoint still referencing
|
|
the pre-delta blob version - those pending writes postdate the blob and
|
|
are silently dropped: the first message appended after migration vanishes
|
|
from materialized state.
|
|
|
|
Both the base implementation (used by the SQLite savers) and the Postgres
|
|
override collect the terminating checkpoint's writes *before* treating its
|
|
blob as the seed, which is the correct order. This patch delegates
|
|
InMemorySaver to the base implementation - one ``get_tuple`` per ancestor
|
|
instead of a single fused walk, which is fine for dict-backed storage.
|
|
|
|
Idempotent. Guarded: stands down when the upstream override disappears or
|
|
the assignment fails, and warns once LangGraph moves past the validated
|
|
version so the patch is re-inspected instead of silently overriding an
|
|
upstream fix. Remove once LangGraph fixes the override upstream (no
|
|
upstream issue exists yet; re-check ``InMemorySaver.get_delta_channel_history``
|
|
on every langgraph upgrade).
|
|
"""
|
|
if getattr(InMemorySaver, _PATCH_FLAG, False):
|
|
return
|
|
try:
|
|
langgraph_version = Version(importlib.metadata.version("langgraph"))
|
|
except Exception:
|
|
langgraph_version = _PATCH_VALIDATED_LANGGRAPH_VERSION
|
|
if langgraph_version > _PATCH_VALIDATED_LANGGRAPH_VERSION:
|
|
logger.warning(
|
|
"langgraph %s is newer than the version (%s) the InMemorySaver delta-history patch was validated against; re-inspect the upstream override before relying on the patch.",
|
|
langgraph_version,
|
|
_PATCH_VALIDATED_LANGGRAPH_VERSION,
|
|
)
|
|
try:
|
|
if not _upstream_override_present():
|
|
# Upstream removed its override (fixed or refactored): the base
|
|
# implementation is already in use, nothing to patch.
|
|
return
|
|
InMemorySaver.get_delta_channel_history = _get_delta_channel_history_via_base # type: ignore[method-assign]
|
|
InMemorySaver.aget_delta_channel_history = _aget_delta_channel_history_via_base # type: ignore[method-assign]
|
|
InMemorySaver._deerflow_delta_history_patched = True # type: ignore[attr-defined]
|
|
except (AttributeError, TypeError):
|
|
logger.warning("Failed to apply the InMemorySaver delta-history patch; leaving the upstream implementation untouched.", exc_info=True)
|
|
|
|
|
|
ensure_inmemory_delta_history_patch()
|