mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-11-04 01:20:36 +00:00
e0f5483fdf
* fix(goal): fall back gracefully for an unsupported reply locale goal_reply_text and goal_status_text indexed _TEXT directly with the caller's locale, so a locale outside NotificationLocale (en-US/zh-CN) raised KeyError. The /connect handshake (connect_reply_text) normalizes with supported_locale and falls back to en-US; the /goal replies must do the same instead of surfacing an internal error to the user. Normalize the locale in both public entry points. Adds tests pinning the fallback for an unknown locale and the zh-CN wording for a supported one. * style(tests): format goal status locale assertion --------- Co-authored-by: lisry-1 <249596828+lisry-1@users.noreply.github.com> Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
26 lines
1.1 KiB
Python
26 lines
1.1 KiB
Python
"""Tests for ``/goal`` reply text locale handling.
|
|
|
|
``goal_status.py`` hosts its own reply wording and, unlike the ``/connect``
|
|
handshake, used to index its ``_TEXT`` table directly with the caller's locale.
|
|
A locale outside ``NotificationLocale`` therefore raised ``KeyError`` instead of
|
|
falling back, which is the opposite of ``connect_reply_text``. These tests pin
|
|
the fallback behavior.
|
|
"""
|
|
|
|
from app.channels.goal_status import goal_reply_text, goal_status_text
|
|
|
|
|
|
def test_goal_reply_text_unknown_locale_falls_back_to_default():
|
|
"""A locale outside NotificationLocale must fall back, not raise KeyError."""
|
|
assert goal_reply_text("none", "ja-JP") == "No active goal."
|
|
|
|
|
|
def test_goal_reply_text_known_zh_locale():
|
|
"""A supported locale still selects its own wording."""
|
|
assert goal_reply_text("none", "zh-CN") == "当前没有目标。"
|
|
|
|
|
|
def test_goal_status_text_unknown_locale_falls_back_to_default():
|
|
"""The status reply also falls back for an unsupported locale."""
|
|
assert goal_status_text(None, None, running=False, locale="ja-JP") == "No active goal."
|