deer-flow

mirror of https://github.com/bytedance/deer-flow.git synced 2026-10-26 21:26:39 +00:00

History

fix(auth): reject a non-ASCII ID token nonce instead of raising (#6115 )

* fix(auth): reject a non-ASCII ID token nonce instead of raising

The nonce comparison in validate_id_token still used the local
secrets.compare_digest on str operands, which raises TypeError when either
side holds non-ASCII characters. The nonce claim is provider-controlled
text, so such a provider response turned the callback's sso_failed redirect
(OIDCValidationError) into an unhandled 500.

Route it through the shared constant_time_equals helper #6076 introduced
for the same five compare sites, and drop the now-unused local helper.

Signed-off-by: yetuge <2219677952@qq.com>

* fix(auth): reject a non-string ID token nonce claim like a mismatch

A provider returning a truthy non-string nonce claim (e.g. an int)
slipped past the missing-claim guard and crashed the comparison helper
with AttributeError, which the callback turned into a 500 instead of
the sso_failed redirect. Guard the claim type before comparing so every
malformed nonce takes the same OIDCValidationError path.

Signed-off-by: yetuge <2219677952@qq.com>

---------

Signed-off-by: yetuge <2219677952@qq.com>
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>

2026-10-01 07:43:16 +08:00

repositories

fix(auth): claim the first admin atomically instead of counting first (#5776 )

2026-09-24 16:30:36 +08:00

__init__.py

feat(auth): release-validation pass for 2.0-rc — 12 blockers + simplify follow-ups (#2008 )

2026-04-26 11:08:11 +08:00

config.py

fix(auth): persist auto-generated JWT secret to survive restarts (#2933 )

2026-05-16 09:24:40 +08:00

credential_file.py

feat(auth): release-validation pass for 2.0-rc — 12 blockers + simplify follow-ups (#2008 )