laoyyu a50663c2f1
fix(uploads): reject colons in normalize_filename like the skill installer (#8351)
* fix(uploads): reject colons in normalize_filename like the skill installer

normalize_filename() accepted a ':' in the basename, so the three upload
writer paths disagreed for the same name on Windows: the streaming write
(write_upload_file_no_symlink) happily stored the bytes in an invisible
NTFS Alternate Data Stream ("notes.txt:hidden" attaches a stream to
notes.txt; directory listings report the base file with 0 new bytes),
while copy/publish raised WinError 123 outright.

skills.installer.is_unsafe_zip_member already rejects any member path
containing ':' with exactly this rationale (drive letters are caught
earlier as absolute paths; a stray colon addresses an ADS that is
invisible to rglob/os.walk listings). Apply the same rule to upload
filenames so every writer path rejects the name identically.

* docs(uploads): clarify colon rejection and drive paths

---------

Co-authored-by: laoyyu <laoyyu@users.noreply.github.com>
Co-authored-by: Nan Gao <thunderggnn@gmail.com>
2026-11-18 18:55:06 +08:00
..