mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-24 17:43:45 +00:00
84dccef230
Finish Phase 2 of the config refactor: production code no longer calls AppConfig.current() anywhere. AppConfig now flows as an explicit parameter down every consumer lane. Call-site migrations -------------------- - Memory subsystem (queue/updater/storage): MemoryConfig captured at enqueue time so the Timer closure survives the ContextVar boundary. - Sandbox layer: tools.py, security.py, sandbox_provider.py, local_sandbox_provider, aio_sandbox_provider all take app_config explicitly. Module-level caching in tools.py's path helpers is removed — pure parameter flow. - Skills layer: manager.py + loader.py + lead_agent.prompt cache refresh all thread app_config; cache worker closes over it. - Community tools (tavily, jina, firecrawl, exa, ddg, image_search, infoquest, aio_sandbox): read runtime.context.app_config. - Subagents registry: get_subagent_config / list_subagents / get_available_subagent_names require app_config. - Runtime worker: requires RunContext.app_config; no fallback. - Gateway routers (uploads, skills): add Depends(get_config). - Channels feishu: uses AppConfig.from_file() (pure) at its sync boundary. - LangGraph Server bootstrap (make_lead_agent): falls back to AppConfig.from_file() — pure load, not ambient lookup. Context resolution ------------------ - resolve_context(runtime) now raises on non-DeerFlowContext runtime.context. Every entry point attaches typed context; dict/None shapes are rejected loudly instead of being papered over with an ambient AppConfig lookup. AppConfig lifecycle ------------------- - AppConfig.current() kept as a deprecated slot that raises RuntimeError, purely so legacy tests that still run `patch.object(AppConfig, "current")` don't trip AttributeError at teardown. Production never calls it. - conftest autouse fixture no longer monkey-patches `current` — it only stubs `from_file()` so tests don't need a real config.yaml. Design refs ----------- - docs/plans/2026-04-12-config-refactor-plan.md (Phase 2: P2-6..P2-10) - docs/plans/2026-04-12-config-refactor-design.md §8 All 2338 non-e2e tests pass. Zero AppConfig.current() call sites remain in backend/packages or backend/app (docstrings in deps.py excepted).
42 lines
1.9 KiB
Python
42 lines
1.9 KiB
Python
|
|
# --- Phase 2 config-refactor test helper ---
|
|
# Memory APIs now take MemoryConfig / AppConfig explicitly. Tests construct a
|
|
# minimal config once and reuse it across call sites.
|
|
from deerflow.config.app_config import AppConfig as _TestAppConfig
|
|
from deerflow.config.memory_config import MemoryConfig as _TestMemoryConfig
|
|
from deerflow.config.sandbox_config import SandboxConfig as _TestSandboxConfig
|
|
|
|
_TEST_MEMORY_CONFIG = _TestMemoryConfig(enabled=True)
|
|
_TEST_APP_CONFIG = _TestAppConfig(sandbox=_TestSandboxConfig(use="test"), memory=_TEST_MEMORY_CONFIG)
|
|
# -------------------------------------------
|
|
|
|
"""Tests for user_id propagation in memory updater."""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from deerflow.agents.memory.updater import get_memory_data, clear_memory_data, _save_memory_to_file
|
|
|
|
|
|
def test_get_memory_data_passes_user_id():
|
|
mock_storage = MagicMock()
|
|
mock_storage.load.return_value = {"version": "1.0"}
|
|
with patch("deerflow.agents.memory.updater.get_memory_storage", return_value=mock_storage):
|
|
get_memory_data(_TEST_MEMORY_CONFIG, user_id="alice")
|
|
mock_storage.load.assert_called_once_with(None, user_id="alice")
|
|
|
|
|
|
def test_save_memory_passes_user_id():
|
|
mock_storage = MagicMock()
|
|
mock_storage.save.return_value = True
|
|
with patch("deerflow.agents.memory.updater.get_memory_storage", return_value=mock_storage):
|
|
_save_memory_to_file(_TEST_MEMORY_CONFIG, {"version": "1.0"}, user_id="bob")
|
|
mock_storage.save.assert_called_once_with({"version": "1.0"}, None, user_id="bob")
|
|
|
|
|
|
def test_clear_memory_data_passes_user_id():
|
|
mock_storage = MagicMock()
|
|
mock_storage.save.return_value = True
|
|
with patch("deerflow.agents.memory.updater.get_memory_storage", return_value=mock_storage):
|
|
clear_memory_data(_TEST_MEMORY_CONFIG, user_id="charlie")
|
|
# Verify save was called with user_id
|
|
assert mock_storage.save.call_args.kwargs["user_id"] == "charlie"
|