mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-11-20 03:10:34 +00:00
* feat(goal): add /goal from-chat for IM channels First slice of #7050: add an explicit IM command that composes the active goal from the recent conversation instead of taking the text literally. Natural-language intent detection remains out of scope. Gateway: - POST /api/threads/{thread_id}/goal/from-chat synthesizes the objective from the thread summary and recent agreement turns (visible user/assistant text, clarification questions, and card answers), preserving agreed constraints and the stopping condition. - Reject a busy thread before the model call; the save reuses the existing checkpoint-write reservation so a run that starts mid-synthesis still wins. - Refuse to synthesize while a human-input request is unanswered, and return structured no_context/unclear/synthesis_failed outcomes without echoing model-generated reasons. IM: - /goal from-chat [hint] shows the saved objective, then starts exactly one run through the ordinary chat path; a longer read timeout covers synthesis. - Map busy/pending/unclear/no-context/timeout outcomes to localized replies; a saved goal whose run cannot start is reported honestly. - The TUI explains that from-chat is not supported yet; the web input box still treats it literally (documented follow-up). Docs: README, CHANGELOG, IM channel guide, TUI guide, AGENTS, and the acceptance plan/execution record. Tests: new route, synthesis and manager suites, plus parser and TUI coverage. * fix(goal): keep the from-chat confirmation visible on every channel The saved-objective reply was published as a non-final progress update. QQ and DingTalk card mode drop non-final outbounds before a stream exists, and Feishu/Telegram fold the update into the run's stream, so the run output overwrote the objective. Publish it as the turn's final message. Redact PII on whole lines and the summary before the context budget can split an identifier; the composed prompt is still redacted once more as defense in depth, matching the goal evaluator's direct call. Also correct the gateway/IM docs (from-chat never creates a checkpoint, the busy pre-check is worker-local, and synthesis uses the deployment default model), fix the route test clock patch, and add regression tests for the final-outbound and truncation-boundary cases. * fix(goal): align from-chat with the goal-route admission gates Reject a from-chat save while a tool approval is pending, matching PUT/DELETE /goal, and suppress subagent-batch continuations queued under the previous goal after the save. Both invariants landed upstream while this branch was in review; the new route now shares them. Add route tests for both behaviors. * docs(changelog): remove the from-chat entry to avoid conflicts The maintainer asked to drop the changelog entry because the section conflicts with upstream changes. The feature remains documented in the goals guide and README. * fix(goal): close three review gaps in /goal from-chat - Enforce model-use authorization for the deployment default model before the synthesis call, matching the suggestions route, so a denied role never sends conversation context to the model. - Save with expected_checkpoint_id pinned to the head the synthesis read; a write that landed during the model call is a 409 goal_changed instead of silently clobbering the newer goal. - Re-check the conversation binding before starting the run: a /new during synthesis keeps the goal in the original thread and reports that the task did not start instead of running it in the switched conversation. * fix(goal): preserve from-chat handoff and run status Pin the saved thread through run preparation and reject a changed binding. Read configuration and model authorization off the event loop, and report rejected starts separately from requests whose response was lost. Cover the handoff races and streaming/wait admission outcomes through the real channel manager and SDK transport, plus file-backed config under the strict blocking-I/O detector. Co-authored-by: Loveca <44801706+Loveca@users.noreply.github.com> * fix(goal): preserve reasoning tags in synthesis JSON Use the existing JSON-aware reasoning stripper so literal tag text in objective and reason values survives parsing. Cover complete and unclosed tags while still removing model reasoning before the JSON payload. Co-authored-by: Loveca <44801706+Loveca@users.noreply.github.com> --------- Co-authored-by: Totoro-qaq <279883115+Totoro-qaq@users.noreply.github.com> Co-authored-by: Totoro <msy626836554@gmail.com>
153 lines
9.4 KiB
Python
153 lines
9.4 KiB
Python
"""Text of the IM ``/goal`` replies, mirroring the web goal bar.
|
||
|
||
The status reply follows ``describeGoalBar`` in
|
||
``frontend/src/components/workspace/goal-status-helpers.ts``: an active goal
|
||
wins over a met record; while a run is in flight, a stand-down left by an
|
||
earlier run is not shown; when idle, a stand-down, then a paused auto-continue,
|
||
then a plain set goal. Stop reasons are host-written codes
|
||
(``contracts/thread_goal_contract.json``) worded with the scheduled-notice
|
||
texts; the evaluator's own words and provider errors are never sent. A met goal
|
||
is cleared and recorded as ``goal_outcome``, which reads as met until the next
|
||
goal change.
|
||
"""
|
||
|
||
from __future__ import annotations
|
||
|
||
import math
|
||
from collections.abc import Mapping
|
||
|
||
from app.channels.reply_locale import supported_locale
|
||
from app.scheduler.notification_text import goal_reason_text
|
||
from deerflow.persistence.scheduled_task_runs.finalization import CHECK_FAILURE_CODES
|
||
from deerflow.runtime.goal import is_active_goal
|
||
|
||
_TEXT: dict[str, dict[str, str]] = {
|
||
"en-US": {
|
||
"goal": "Goal: {objective}",
|
||
"met": "Goal met: {objective}",
|
||
"met_with_assumption": "Goal met, with an assumption: {objective}",
|
||
"none": "No active goal.",
|
||
"in_progress": "In progress.",
|
||
"continuing": "In progress: auto-continued {count}/{max} times.",
|
||
"paused": "Paused: auto-continued {count}/{max} times; the run ended before the goal was confirmed.",
|
||
"stopped": "Stopped: {reason}.",
|
||
"stopped_bare": "Stopped.",
|
||
"waiting_for_you": "Waiting for you: {reason}.",
|
||
"waiting": "Waiting: {reason}.",
|
||
"unchecked": "{reason}. It's checked again after your next message.",
|
||
"cleared": "Goal cleared.",
|
||
"fetch_failed": "Failed to fetch goal information.",
|
||
"clear_failed": "Failed to clear goal.",
|
||
"set_failed": "Failed to set goal.",
|
||
"busy": "A task is still running. Wait for it to finish before changing the goal.",
|
||
"from_chat_saved": "Goal set from the conversation: {objective}",
|
||
"from_chat_saved_but_not_started": "Goal saved from the conversation, but the task did not start. Send any message to pick it up, or check /goal.",
|
||
"from_chat_run_status_unknown": "Goal saved from the conversation. I couldn't confirm the task's status, and it may still be running. Check the conversation in DeerFlow before sending it again.",
|
||
"from_chat_unclear": "I couldn't form a clear goal from this conversation. Try adding a hint, e.g. /goal from-chat focus on the vendor totals.",
|
||
"from_chat_no_context": "There is no conversation content to build a goal from yet. Discuss the task first, or set it directly with /goal <objective>.",
|
||
"from_chat_pending_clarification": "The assistant is still waiting for your answer in this conversation. Reply to it first, then retry /goal from-chat.",
|
||
"from_chat_no_thread": "No conversation yet. Send a message first, then ask /goal from-chat.",
|
||
"from_chat_changed": "The conversation changed while the goal was being composed, so nothing was saved. Retry /goal from-chat, or set it directly with /goal <objective>.",
|
||
"from_chat_conversation_switched": "This chat switched to a new conversation while the goal was being composed, so the task did not start. The goal remains saved in the previous conversation: {objective}",
|
||
"from_chat_timeout": "Timed out waiting for the goal to be composed. The save may still finish — check with /goal, and retry if there is no goal.",
|
||
"from_chat_failed": "Failed to compose the goal from the conversation. Try again, or set it directly with /goal <objective>.",
|
||
},
|
||
"zh-CN": {
|
||
"goal": "目标:{objective}",
|
||
"met": "目标已达成:{objective}",
|
||
"met_with_assumption": "目标已达成(含假设):{objective}",
|
||
"none": "当前没有目标。",
|
||
"in_progress": "进行中。",
|
||
"continuing": "进行中:已自动续跑 {count}/{max} 次。",
|
||
"paused": "已暂停:已自动续跑 {count}/{max} 次,运行在确认达成前结束了。",
|
||
"stopped": "已停止:{reason}。",
|
||
"stopped_bare": "已停止。",
|
||
"waiting_for_you": "等你回复:{reason}。",
|
||
"waiting": "等待中:{reason}。",
|
||
"unchecked": "{reason}。下次发消息后会重新检查。",
|
||
"cleared": "目标已清除。",
|
||
"fetch_failed": "无法获取目标信息。",
|
||
"clear_failed": "无法清除目标。",
|
||
"set_failed": "无法设置目标。",
|
||
"busy": "当前任务仍在运行,请等待结束后再修改目标。",
|
||
"from_chat_saved": "已从对话设置目标:{objective}",
|
||
"from_chat_saved_but_not_started": "目标已从对话保存,但任务未能启动。发送任意消息即可继续,或用 /goal 查看状态。",
|
||
"from_chat_run_status_unknown": "目标已从对话保存,但暂时无法确认任务状态,任务可能仍在运行。请先在 DeerFlow 中查看会话,再决定是否重试。",
|
||
"from_chat_unclear": "无法从当前对话中形成清楚的目标。可以补充提示,例如 /goal from-chat 重点核对供应商合计。",
|
||
"from_chat_no_context": "当前对话还没有可用于构建目标的内容。先讨论任务,或用 /goal <目标> 直接设置。",
|
||
"from_chat_pending_clarification": "助手还在等你回答对话里的问题。先回复它,再重试 /goal from-chat。",
|
||
"from_chat_no_thread": "还没有会话。先发一条消息,再用 /goal from-chat。",
|
||
"from_chat_changed": "生成目标期间对话内容发生了变化,本次未保存。请重试 /goal from-chat,或用 /goal <目标> 直接设置。",
|
||
"from_chat_conversation_switched": "生成目标期间当前聊天切换到了新会话,任务没有启动。目标仍保存在之前的会话里:{objective}",
|
||
"from_chat_timeout": "从对话生成目标超时。保存可能仍会完成——先用 /goal 查看,如果没有再重试。",
|
||
"from_chat_failed": "从对话生成目标失败。请重试,或用 /goal <目标> 直接设置。",
|
||
},
|
||
}
|
||
|
||
# Stand-downs where the user, or something outside DeerFlow, acts next (the web bar's chips).
|
||
_WAITING_KEYS = {"needs_user_input": "waiting_for_you", "external_wait": "waiting"}
|
||
|
||
|
||
def goal_reply_text(key: str, locale: str) -> str:
|
||
"""A fixed ``/goal`` reply (``none``, ``cleared``, ``*_failed``) in ``locale``."""
|
||
locale = supported_locale(locale)
|
||
return _TEXT[locale][key]
|
||
|
||
|
||
def is_active_goal_state(value: object) -> bool:
|
||
"""An active goal with an objective, the web bar's ``isGoalState``."""
|
||
return is_active_goal(value) and isinstance(value.get("objective"), str)
|
||
|
||
|
||
def _count(value: object) -> int:
|
||
"""A positive whole count, else 0 (the web bar's ``countOf``)."""
|
||
if isinstance(value, bool) or not isinstance(value, int | float) or not math.isfinite(value) or value <= 0:
|
||
return 0
|
||
return math.floor(value)
|
||
|
||
|
||
def _stop_line(code: str, max_continuations: int, locale: str) -> str:
|
||
"""Why auto-continue stood down, by who acts next (the web bar's ``stopRowOf``)."""
|
||
text = _TEXT[locale]
|
||
if code in CHECK_FAILURE_CODES:
|
||
# Not a verdict: the goal is checked again after the next message.
|
||
reason = goal_reason_text(code, locale)
|
||
return text["unchecked"].format(reason=reason[:1].upper() + reason[1:]) if reason else text["stopped_bare"]
|
||
bare = code.removeprefix("blocked:")
|
||
if bare == "max_continuations_reached" and max_continuations <= 0:
|
||
# Auto-continue was off for this goal: the check just found it unmet.
|
||
bare = "goal_not_met_yet"
|
||
reason = goal_reason_text(bare, locale)
|
||
if reason is None:
|
||
return text["stopped_bare"]
|
||
return text[_WAITING_KEYS.get(bare, "stopped")].format(reason=reason)
|
||
|
||
|
||
def goal_status_text(goal: object, outcome: object, *, running: bool, locale: str) -> str:
|
||
"""The ``/goal`` status reply: the active goal and its state, a met goal, or none.
|
||
|
||
``running`` says whether the thread has a run pending or in progress.
|
||
"""
|
||
locale = supported_locale(locale)
|
||
text = _TEXT[locale]
|
||
if is_active_goal_state(goal):
|
||
lines = [text["goal"].format(objective=goal["objective"])]
|
||
evaluation = goal.get("last_evaluation")
|
||
evaluation = evaluation if isinstance(evaluation, Mapping) else None
|
||
code = evaluation.get("stand_down_reason") if evaluation is not None else None
|
||
code = code.strip() if isinstance(code, str) else ""
|
||
count = _count(goal.get("continuation_count"))
|
||
maximum = _count(goal.get("max_continuations"))
|
||
if running:
|
||
satisfied = evaluation is not None and evaluation.get("satisfied") is True
|
||
lines.append(text["continuing"].format(count=count, max=maximum) if not code and not satisfied and count > 0 else text["in_progress"])
|
||
elif code:
|
||
lines.append(_stop_line(code, maximum, locale))
|
||
elif evaluation is not None and count > 0:
|
||
lines.append(text["paused"].format(count=count, max=maximum))
|
||
return "\n".join(lines)
|
||
if isinstance(outcome, Mapping) and outcome.get("status") == "achieved" and isinstance(outcome.get("objective"), str) and isinstance(outcome.get("goal_created_at"), str):
|
||
key = "met_with_assumption" if outcome.get("relied_on_assumption") is True else "met"
|
||
return text[key].format(objective=outcome["objective"])
|
||
return text["none"]
|