Hyeonsang Cho bbab1e84d0

fix(uploads): never let a malformed files[*].size abort the run (#5855) ...

* fix(uploads): never let a malformed files[*].size abort the run

UploadsMiddleware._files_from_kwargs validates every field of a
client-supplied file entry fail-soft — non-dict entries, non-basename or
staging filenames, and files missing from the uploads dir are all skipped —
except `size`, which went straight to int(). A value int() cannot convert
("abc", a list, inf) raised ValueError/TypeError/OverflowError out of
before_agent (and the executor-wrapped abefore_agent), failing the whole run
before the model was called. The Gateway strips only server-owned metadata
keys and edit/regenerate deep-copies `files` verbatim, so the same entry
failed again on every retry of that message.

The size only feeds the human-readable "(N KB)" line in <current_uploads>,
so route it through _coerce_file_size: a non-negative finite number (or a
numeric string such as "2048") is kept as int; None, bools, negatives,
non-finite floats and anything unconvertible fall back to 0, the value a
missing size already gets.

Tests pin the fallback for each unusable shape, the kept values, and that
before_agent still injects an existing upload whose size is malformed.

* docs(changelog): reference #5855 in the uploads size entries

---------

Co-authored-by: Willem Jiang <willem.jiang@gmail.com>

2026-09-25 22:35:28 +08:00

..

extension-api

feat(extensions): grant bounded host model invocation (#5796)

2026-09-25 15:24:09 +08:00

harness

fix(uploads): never let a malformed files[*].size abort the run (#5855)

2026-09-25 22:35:28 +08:00