Nan Gao 7389331e65
feat(extensions): observe task lifecycle and system model calls (#4684)
* feat(extensions): observe task lifecycle and system model calls

PR 1 (#4636) gave extensions a middleware chain, and a middleware only sees
what passes through the agent graph. Two runtime surfaces stay invisible to
it: when a lead run or a subagent begins and ends, and the DeerFlow-owned
model calls made outside the graph. This slice adds both, with no new
Gateway surface -- routers, services, and the reference extension stay in
PR 3.

Contract (deerflow-extension-api 0.1.1)
---------------------------------------
Two contribution kinds join `middlewares` on the registry:
`task_lifecycle` (`on_task_start` / `on_task_stop`, receiving a `TaskInfo`
and a conservative `TaskOutcome` of completed / aborted / failed) and
`system_model_observer` (`on_system_model_call`, receiving a
`SystemOperationKind`, a `SystemModelRequest` snapshot, and a
`SystemModelResult` carrying either the response or the provider exception
plus a duration).

`SystemModelRequest.messages` normalizes to a tuple at construction. Goal
evaluation and memory extraction pass a message list while title generation
and summarization pass one prompt string, and a bare `str` already satisfies
`Sequence` -- without normalization an observer iterating `request.messages`
would silently walk characters. Copying also makes the frozen snapshot
immutable in fact rather than only by declaration, since observations may run
after the call site returns and keeps mutating its own list.

Registry marks and rollbacks become per-bucket and positional, so an
`install()` that fails after registering two different kinds cannot leave one
of them behind. `needs_task_store` now covers all three kinds: a deployment
that registers only lifecycle hooks still gets a task store.

Task lifecycle
--------------
The lead worker notifies start after the run has started and stop after
completion persistence and the completion hook, but before clearing the
finalizing barrier and publishing the stream end -- holding the barrier
across stop is what keeps a same-thread replacement run from overlapping this
task's lifecycle. Cancellation raised out of the stop notification is
deferred, not propagated in place, so a cancelled run still clears the
barrier and emits its end frame. A subagent with a parent `run_id` wraps its
execution in the same pair inside `finally`, reporting `parent_task_id` so a
delegation tree is reconstructable; a subagent without a `run_id` (embedded
client, standalone LangGraph Server) logs and skips rather than inventing a
parent. Contributors run in registration order inside one shared 3s budget
and every failure is logged and failed open.

System model calls
------------------
Four kinds cover the model calls the middleware chain cannot see: goal
evaluation, memory extraction, title generation, and summarization. Each site
reports both terminal paths without changing the provider exception the host
observes, short-circuits on `has_system_model_observers`, and passes the live
task store when the runtime has one (detached work gets an isolated store).
The sync summarization half stays unobserved on purpose -- it and its only
host caller are the sync side of an async-only runtime, so notifying there
would block a thread on a call site the host never reaches; the reason is
recorded at the call site.

The DeerMem backend must stay vendorable and cannot import the extension API,
so it reports through a new `MemoryCallbacks.on_memory_llm_result` host hook
that the DeerFlow-side callbacks translate into an observation.

Notification loop
-----------------
Extension resources must be touched on the loop that created them, but
subagents can execute on isolated loops and DeerMem runs on a worker thread.
The Gateway registers its serving loop before any runtime dependency starts
and resets it last through the exit stack, so every startup-failure and
cancellation path is covered. Awaited hooks raised on another loop are
dispatched across with `run_coroutine_threadsafe` and awaited under the same
budget; synchronous sites submit fire-and-forget work. Shutdown stops
accepting detached observations before the memory flush -- that flush runs on
a worker thread and can emit memory observations -- while keeping the loop
alive for awaited task hooks until run and subagent drain completes.

Tests
-----
`test_extension_task_lifecycle.py`, `test_extension_subagent_lifecycle.py`,
and `test_extension_system_model_calls.py` cover ordering, fail-open, budget
exhaustion, snapshot binding under a concurrent singleton replacement, the
loop-dispatch and shutdown-suspension paths, and both terminal paths at every
call site. `test_gateway_run_drain_shutdown.py` pins the stop-before-barrier
and drain ordering.

* fix(extensions): decide notification fail-open by origin, observe cancellation

`_notify_each` only guarded `Exception`, so a contributor letting a
`CancelledError` escape — an extension implementing an internal timeout with
cancellation, say — skipped its successors and reached the worker's
deferred-interrupt path, ending an otherwise successful run as cancelled.
Fail-open is about where a failure came from, not its base class: only a
genuine cancellation of the host task increments `Task.cancelling()`, so
propagate on that and contain everything else. `KeyboardInterrupt` /
`SystemExit` still propagate.

`observe_system_model_call` skipped observers on cancellation for the same
base-class reason, leaving goal / title / summarization silent on a terminal
path that is routine — interrupt/rollback admission and shutdown both cancel
the run task, with the provider tokens already spent. Awaiting observers there
is unreliable (a repeated cancel interrupts that await before any of them
runs), so report through the same non-blocking submission the synchronous
memory bridge uses, then propagate the cancellation untouched.

DeerMem keeps `BaseException` around its provider call, now with the reason
recorded: that path runs on a worker thread, where cancelling the awaiting
side never interrupts the running thread, so `CancelledError` cannot arrive
at all. Its host-hook wrapper narrows to `Exception` — only the hook's own
failures are non-fatal, and an observability path must not swallow a process
teardown signal.

* fix(extensions): warn on budget exhaustion, scope observer logs by task, propagate teardown

Review response on #4684:

- The memory observation bridge caught BaseException, which would swallow
  a teardown signal raised while dispatching; it now catches Exception,
  matching the boundary the DeerMem-side call site documents and tests.
- A notification-budget timeout raised mid-hook fell into the generic
  hook-failure path and logged an asyncio-internal traceback; it now logs
  a warning like the pre-hook budget skip, while a TimeoutError a
  contributor raises on its own stays classified as a hook failure.
- System model observer logs passed the operation kind as the task id,
  so log lines said "task goal/title/..."; they now carry the task
  scope id alongside the kind.
2026-08-11 16:33:22 +08:00

201 lines
6.2 KiB
Python

"""The extension contracts and their data types.
Compatibility rules enforced throughout this module:
* every Protocol method carries a default implementation, so adding a method
later stays additive for already-released extensions;
* every optional dataclass field carries a default, so adding a field stays
additive.
"""
from __future__ import annotations
from collections.abc import Callable, Mapping, Sequence
from dataclasses import dataclass
from enum import StrEnum
from typing import TYPE_CHECKING, Any, Literal, Protocol, TypeVar, runtime_checkable
from deerflow_extension_api.state import ExtensionData
if TYPE_CHECKING: # pragma: no cover - typing only
from deerflow_extension_api.placement import AgentBuildContext, MiddlewarePlacement
F = TypeVar("F", bound=Callable[..., Any])
# --- Host projections -------------------------------------------------------
@dataclass(frozen=True)
class HostPolicySnapshot:
"""The limits the host actually enforces, projected for extensions.
A narrow projection instead of the host's AppConfig: exposing AppConfig
would pin every extension to the harness release cadence. Every field has
a default so widening this stays additive.
"""
token_budget_enabled: bool = False
max_input_tokens: int | None = None
max_output_tokens: int | None = None
max_total_tokens: int | None = None
budget_warn_fraction: float | None = None
budget_hard_fraction: float | None = None
max_subagents_per_run: int | None = None
# --- Task lifecycle ---------------------------------------------------------
class TaskOutcome(StrEnum):
COMPLETED = "completed"
ABORTED = "aborted"
FAILED = "failed"
@dataclass(frozen=True)
class TaskInfo:
"""Identity of one lead-agent or subagent execution."""
task_id: str
run_id: str
thread_id: str
kind: Literal["lead", "subagent"]
parent_task_id: str | None = None
agent_name: str | None = None
resumed: bool = False
class TaskLifecycleContributor(Protocol):
async def on_task_start(
self,
app_store: ExtensionData,
task_store: ExtensionData,
info: TaskInfo,
) -> None:
return None
async def on_task_stop(
self,
app_store: ExtensionData,
task_store: ExtensionData,
info: TaskInfo,
outcome: TaskOutcome,
) -> None:
return None
# --- System model calls not wrapped by middleware model-call hooks ----------
class SystemOperationKind(StrEnum):
GOAL = "goal"
MEMORY = "memory"
TITLE = "title"
SUMMARIZATION = "summarization"
@dataclass(frozen=True)
class SystemModelRequest:
"""Read-only snapshot taken before a system-owned model call."""
messages: Sequence[Any] = ()
model_name: str | None = None
invoke_config: Mapping[str, Any] | None = None
def __post_init__(self) -> None:
"""Normalize ``messages`` to a tuple so the snapshot is what it claims to be.
Call sites differ: goal evaluation and memory extraction pass a message list,
while title generation and summarization pass one prompt string. A bare ``str``
already satisfies ``Sequence``, so without this an observer iterating
``request.messages`` would silently walk characters. Copying a list also makes
the frozen snapshot immutable in fact, not only by dataclass declaration — the
caller keeps its own list and observations may run after the call returns.
"""
messages = self.messages
if isinstance(messages, tuple):
return
normalized = tuple(messages) if isinstance(messages, Sequence) and not isinstance(messages, str | bytes) else (messages,)
object.__setattr__(self, "messages", normalized)
@dataclass(frozen=True)
class SystemModelResult:
"""Success or failure snapshot taken after a system-owned model call."""
response: Any | None = None
error: BaseException | None = None
duration_ms: float | None = None
class SystemModelCallObserver(Protocol):
async def on_system_model_call(
self,
app_store: ExtensionData,
task_store: ExtensionData,
kind: SystemOperationKind,
request: SystemModelRequest,
result: SystemModelResult,
) -> None:
return None
# --- Middleware -------------------------------------------------------------
class MiddlewareContributor(Protocol):
def contribute_middlewares(
self,
app_store: ExtensionData,
ctx: AgentBuildContext,
) -> Sequence[MiddlewarePlacement]:
return ()
# --- Registration surface ---------------------------------------------------
@runtime_checkable
class ExtensionRegistry(Protocol):
"""The write-only registration surface handed to ``install()``.
Structural and minimal on purpose. This first capability slice exposes
middleware contribution only; later slices can add defaulted registration
methods without breaking existing implementations. The host's concrete
registry additionally carries host-only machinery (attribution, positional
rollback, build) that is deliberately absent here.
"""
def middlewares(self, contributor: MiddlewareContributor) -> None:
return None
def task_lifecycle(self, contributor: TaskLifecycleContributor) -> None:
return None
def system_model_observer(self, observer: SystemModelCallObserver) -> None:
return None
#: The install() entry point signature every extension exposes.
ExtensionInstall = Callable[[ExtensionRegistry, Mapping[str, Any]], None]
# --- Declaration decorator --------------------------------------------------
def extension(*, api: str, name: str | None = None) -> Callable[[F], F]:
"""Stamp an install function with the API version it was written against.
Optional. pip's dependency resolution is the primary compatibility
mechanism; this covers `--no-deps` installs and editable monorepo checkouts
where versions can skew, and turns a deep AttributeError into an
actionable startup diagnostic.
"""
def _decorate(func: F) -> F:
func.__deerflow_api__ = api # type: ignore[attr-defined]
func.__deerflow_name__ = name # type: ignore[attr-defined]
return func
return _decorate