mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-10-26 13:16:24 +00:00
cdb5028d88
* feat(community): offload image search to a thread via asyncio.to_thread
Make image_search_tool async and run the blocking ddgs call in a worker
thread with asyncio.to_thread, continuing the TODO.md planned feature
('Replace sync requests with httpx.AsyncClient in community tools').
The ddgs SDK exposes no async API, so instead of swapping the HTTP
client the blocking DDGS.images() call is offloaded to a thread — the
same pattern the infoquest/jina_ai tools use for readability
extraction. Callers see no change in behavior.
Tests invoke the async tool via ainvoke under @pytest.mark.anyio.
* fix(image-search): offload config lookup with DDGS search
* test(image-search): pin DDGS search off the event loop
---------
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
36 lines
1.2 KiB
Python
36 lines
1.2 KiB
Python
"""Image search must keep config file reads off the agent event loop."""
|
|
|
|
import threading
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
from deerflow.community.image_search import tools
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
async def test_image_search_config_lookup_does_not_block_loop(monkeypatch) -> None:
|
|
observed_threads: list[threading.Thread] = []
|
|
|
|
def load_config():
|
|
# Keep a real file read in the lookup so the strict blocking-I/O gate
|
|
# fails if the tool resolves config on the event loop.
|
|
Path(__file__).read_text(encoding="utf-8")
|
|
return SimpleNamespace(get_tool_config=lambda _name: None)
|
|
|
|
def probe_search(**_kwargs):
|
|
Path(__file__).read_text(encoding="utf-8")
|
|
observed_threads.append(threading.current_thread())
|
|
return []
|
|
|
|
monkeypatch.setattr(tools, "get_app_config", load_config)
|
|
monkeypatch.setattr(tools, "_search_images", probe_search)
|
|
|
|
result = await tools.image_search_tool.ainvoke({"query": "a cat"})
|
|
|
|
assert '"error": "No images found"' in result
|
|
assert observed_threads, "search must run"
|
|
assert all(thread is not threading.main_thread() for thread in observed_threads)
|