mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-15 21:23:41 +00:00
84dccef230
Finish Phase 2 of the config refactor: production code no longer calls AppConfig.current() anywhere. AppConfig now flows as an explicit parameter down every consumer lane. Call-site migrations -------------------- - Memory subsystem (queue/updater/storage): MemoryConfig captured at enqueue time so the Timer closure survives the ContextVar boundary. - Sandbox layer: tools.py, security.py, sandbox_provider.py, local_sandbox_provider, aio_sandbox_provider all take app_config explicitly. Module-level caching in tools.py's path helpers is removed — pure parameter flow. - Skills layer: manager.py + loader.py + lead_agent.prompt cache refresh all thread app_config; cache worker closes over it. - Community tools (tavily, jina, firecrawl, exa, ddg, image_search, infoquest, aio_sandbox): read runtime.context.app_config. - Subagents registry: get_subagent_config / list_subagents / get_available_subagent_names require app_config. - Runtime worker: requires RunContext.app_config; no fallback. - Gateway routers (uploads, skills): add Depends(get_config). - Channels feishu: uses AppConfig.from_file() (pure) at its sync boundary. - LangGraph Server bootstrap (make_lead_agent): falls back to AppConfig.from_file() — pure load, not ambient lookup. Context resolution ------------------ - resolve_context(runtime) now raises on non-DeerFlowContext runtime.context. Every entry point attaches typed context; dict/None shapes are rejected loudly instead of being papered over with an ambient AppConfig lookup. AppConfig lifecycle ------------------- - AppConfig.current() kept as a deprecated slot that raises RuntimeError, purely so legacy tests that still run `patch.object(AppConfig, "current")` don't trip AttributeError at teardown. Production never calls it. - conftest autouse fixture no longer monkey-patches `current` — it only stubs `from_file()` so tests don't need a real config.yaml. Design refs ----------- - docs/plans/2026-04-12-config-refactor-plan.md (Phase 2: P2-6..P2-10) - docs/plans/2026-04-12-config-refactor-design.md §8 All 2338 non-e2e tests pass. Zero AppConfig.current() call sites remain in backend/packages or backend/app (docstrings in deps.py excepted).
63 lines
2.4 KiB
Python
63 lines
2.4 KiB
Python
"""Tests for DeerFlowContext and resolve_context()."""
|
|
|
|
from dataclasses import FrozenInstanceError
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from deerflow.config.app_config import AppConfig
|
|
from deerflow.config.deer_flow_context import DeerFlowContext, resolve_context
|
|
from deerflow.config.sandbox_config import SandboxConfig
|
|
|
|
|
|
def _make_config(**overrides) -> AppConfig:
|
|
defaults = {"sandbox": SandboxConfig(use="test")}
|
|
defaults.update(overrides)
|
|
return AppConfig(**defaults)
|
|
|
|
|
|
class TestDeerFlowContext:
|
|
def test_frozen(self):
|
|
ctx = DeerFlowContext(app_config=_make_config(), thread_id="t1")
|
|
with pytest.raises(FrozenInstanceError):
|
|
ctx.app_config = _make_config()
|
|
|
|
def test_fields(self):
|
|
config = _make_config()
|
|
ctx = DeerFlowContext(app_config=config, thread_id="t1", agent_name="test-agent")
|
|
assert ctx.thread_id == "t1"
|
|
assert ctx.agent_name == "test-agent"
|
|
assert ctx.app_config is config
|
|
|
|
def test_agent_name_default(self):
|
|
ctx = DeerFlowContext(app_config=_make_config(), thread_id="t1")
|
|
assert ctx.agent_name is None
|
|
|
|
def test_thread_id_required(self):
|
|
with pytest.raises(TypeError):
|
|
DeerFlowContext(app_config=_make_config()) # type: ignore[call-arg]
|
|
|
|
|
|
class TestResolveContext:
|
|
def test_returns_typed_context_directly(self):
|
|
"""Gateway/Client path: runtime.context is DeerFlowContext → return as-is."""
|
|
config = _make_config()
|
|
ctx = DeerFlowContext(app_config=config, thread_id="t1")
|
|
runtime = MagicMock()
|
|
runtime.context = ctx
|
|
assert resolve_context(runtime) is ctx
|
|
|
|
def test_raises_on_none_context(self):
|
|
"""Without a typed DeerFlowContext, resolve_context refuses to guess."""
|
|
runtime = MagicMock()
|
|
runtime.context = None
|
|
with pytest.raises(RuntimeError, match="resolve_context: runtime.context is not a DeerFlowContext"):
|
|
resolve_context(runtime)
|
|
|
|
def test_raises_on_dict_context(self):
|
|
"""Legacy dict shape is no longer supported — we raise instead of lazily loading AppConfig."""
|
|
runtime = MagicMock()
|
|
runtime.context = {"thread_id": "old-dict", "agent_name": "from-dict"}
|
|
with pytest.raises(RuntimeError, match="resolve_context: runtime.context is not a DeerFlowContext"):
|
|
resolve_context(runtime)
|