mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-11-08 03:30:34 +00:00
24d93399fb
* Keep the Windows SID lookup alive on non-UTF-8 console output `_resolve_current_user_sid` calls `whoami /user /fo csv /nh` in text mode without an encoding. `make dev` and `make gateway` start the Gateway with PYTHONUTF8=1, so on a Chinese Windows host the interpreter decodes as UTF-8 while whoami writes the account name in the console's ANSI code page. The strict decode raises inside subprocess's reader thread; the exception is not re-raised, so stdout comes back as None and the credential-tree hardening walk dies with `AttributeError: 'NoneType' object has no attribute 'strip'` before any directory is created or hardened. Pin the encoding and keep an errors policy. The SID is the second CSV field and is pure ASCII, as are the delimiters, so replacing the undecodable account name is harmless. #6590 pinned the seven lark-cli/npm captures in this file; this is the eighth text-mode capture and, unlike those, does not emit UTF-8, so the errors policy is the part that matters here. Add a cross-platform regression test next to the #6590 encoding tests. * docs(lark): correct the SID capture wording `undecodable` is the spelling used elsewhere in the repository, and the comment about the console code page reads better as "which does not need to match". No behaviour change. --------- Co-authored-by: Willem Jiang <willem.jiang@gmail.com>