mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-04-25 11:18:22 +00:00
90299e2710
* feat(provisioner): add optional PVC support for sandbox volumes (#1978) Add SKILLS_PVC_NAME and USERDATA_PVC_NAME env vars to allow sandbox Pods to use PersistentVolumeClaims instead of hostPath volumes. This prevents data loss in production when pods are rescheduled across nodes. When USERDATA_PVC_NAME is set, a subPath of threads/{thread_id}/user-data is used so a single PVC can serve multiple threads. Falls back to hostPath when the new env vars are not set, preserving backward compatibility. * add unit test for provisioner pvc volumes * refactor: extract shared provisioner_module fixture to conftest.py Agent-Logs-Url: https://github.com/bytedance/deer-flow/sessions/e7ccf708-c6ba-40e4-844a-b526bdb249dd Co-authored-by: WillemJiang <219644+WillemJiang@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JeffJiang <for-eleven@hotmail.com>
100 lines
3.1 KiB
Python
100 lines
3.1 KiB
Python
"""Regression tests for provisioner kubeconfig path handling."""
|
|
|
|
from __future__ import annotations
|
|
|
|
|
|
def test_wait_for_kubeconfig_rejects_directory(tmp_path, provisioner_module):
|
|
"""Directory mount at kubeconfig path should fail fast with clear error."""
|
|
kubeconfig_dir = tmp_path / "config_dir"
|
|
kubeconfig_dir.mkdir()
|
|
|
|
provisioner_module.KUBECONFIG_PATH = str(kubeconfig_dir)
|
|
|
|
try:
|
|
provisioner_module._wait_for_kubeconfig(timeout=1)
|
|
raise AssertionError("Expected RuntimeError for directory kubeconfig path")
|
|
except RuntimeError as exc:
|
|
assert "directory" in str(exc)
|
|
|
|
|
|
def test_wait_for_kubeconfig_accepts_file(tmp_path, provisioner_module):
|
|
"""Regular file mount should pass readiness wait."""
|
|
kubeconfig_file = tmp_path / "config"
|
|
kubeconfig_file.write_text("apiVersion: v1\n")
|
|
|
|
provisioner_module.KUBECONFIG_PATH = str(kubeconfig_file)
|
|
|
|
# Should return immediately without raising.
|
|
provisioner_module._wait_for_kubeconfig(timeout=1)
|
|
|
|
|
|
def test_init_k8s_client_rejects_directory_path(tmp_path, provisioner_module):
|
|
"""KUBECONFIG_PATH that resolves to a directory should be rejected."""
|
|
kubeconfig_dir = tmp_path / "config_dir"
|
|
kubeconfig_dir.mkdir()
|
|
|
|
provisioner_module.KUBECONFIG_PATH = str(kubeconfig_dir)
|
|
|
|
try:
|
|
provisioner_module._init_k8s_client()
|
|
raise AssertionError("Expected RuntimeError for directory kubeconfig path")
|
|
except RuntimeError as exc:
|
|
assert "expected a file" in str(exc)
|
|
|
|
|
|
def test_init_k8s_client_uses_file_kubeconfig(tmp_path, monkeypatch, provisioner_module):
|
|
"""When file exists, provisioner should load kubeconfig file path."""
|
|
kubeconfig_file = tmp_path / "config"
|
|
kubeconfig_file.write_text("apiVersion: v1\n")
|
|
|
|
called: dict[str, object] = {}
|
|
|
|
def fake_load_kube_config(config_file: str):
|
|
called["config_file"] = config_file
|
|
|
|
monkeypatch.setattr(
|
|
provisioner_module.k8s_config,
|
|
"load_kube_config",
|
|
fake_load_kube_config,
|
|
)
|
|
monkeypatch.setattr(
|
|
provisioner_module.k8s_client,
|
|
"CoreV1Api",
|
|
lambda *args, **kwargs: "core-v1",
|
|
)
|
|
|
|
provisioner_module.KUBECONFIG_PATH = str(kubeconfig_file)
|
|
|
|
result = provisioner_module._init_k8s_client()
|
|
|
|
assert called["config_file"] == str(kubeconfig_file)
|
|
assert result == "core-v1"
|
|
|
|
|
|
def test_init_k8s_client_falls_back_to_incluster_when_missing(tmp_path, monkeypatch, provisioner_module):
|
|
"""When kubeconfig file is missing, in-cluster config should be attempted."""
|
|
missing_path = tmp_path / "missing-config"
|
|
|
|
calls: dict[str, int] = {"incluster": 0}
|
|
|
|
def fake_load_incluster_config():
|
|
calls["incluster"] += 1
|
|
|
|
monkeypatch.setattr(
|
|
provisioner_module.k8s_config,
|
|
"load_incluster_config",
|
|
fake_load_incluster_config,
|
|
)
|
|
monkeypatch.setattr(
|
|
provisioner_module.k8s_client,
|
|
"CoreV1Api",
|
|
lambda *args, **kwargs: "core-v1",
|
|
)
|
|
|
|
provisioner_module.KUBECONFIG_PATH = str(missing_path)
|
|
|
|
result = provisioner_module._init_k8s_client()
|
|
|
|
assert calls["incluster"] == 1
|
|
assert result == "core-v1"
|