Daoyuan Li 2df7d47b2a
test(llm-error): rename a stand-in, not the shared FakeError (#4744)
* test(llm-error): rename a stand-in, not the shared FakeError

`exc.__class__.__name__ = "ReadError"` on a `FakeError` instance renames the
class itself, so `FakeError` stays named "ReadError" for the rest of the
session and every later test asserting error_type == "FakeError" fails.
Declaration order hides it: the renaming test runs after its victims.

Use the existing _ReadError stand-in, which is already named "ReadError" and
is how the sibling _max_attempts_for test builds the same case. Add an autouse
fixture so a future slip fails the test that causes it.

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* style: format FakeError guard

---------

Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-08-12 08:47:42 +08:00
..